starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 06:05:57 +03:00

[GH-ISSUE #2421] Large File downloads do not fail if curl error #1791

New issue

Open

opened 2026-02-27 02:59:04 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 02:59:04 +03:00

Owner

Originally created by @dgibbs64 on GitHub (Jun 29, 2019).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2421

User Story

If a large download fails using curl it does not cause a fatal error instead it simply carries on.

Basic info

Command: Install

Further Information

It is worth checking how all downloads handle when failing to ensure they cause a fatal exit.

To Reproduce

Use a game server that is non-steam and cause the download to fail

Expected behaviour

Originally created by @dgibbs64 on GitHub (Jun 29, 2019). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2421 ## User Story If a large download fails using curl it does not cause a fatal error instead it simply carries on. ## Basic info * Command: Install ## Further Information It is worth checking how all downloads handle when failing to ensure they cause a fatal exit. ## To Reproduce Use a game server that is non-steam and cause the download to fail ## Expected behaviour

kerem added the

type: bug

command: install

good first issue

labels

2026-02-27 02:59:04 +03:00

kerem commented

2026-02-27 02:59:04 +03:00

Author

Owner

@issue-label-bot[bot] commented on GitHub (Jun 29, 2019):

Issue-Label Bot is automatically applying the label type: bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot[bot] commented on GitHub (Jun 29, 2019): Issue-Label Bot is automatically applying the label `type: bug` to this issue, with a confidence of 0.96. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/GameServerManagers/LinuxGSM) and [code](https://github.com/hamelsmu/MLapp) for this bot.

kerem commented

2026-02-27 02:59:04 +03:00

Author

Owner

@Frisasky commented on GitHub (Jul 19, 2019):

well i think maybe it has something do to with cloudflare, some user also report theres trouble downloading large file(1GB+) and myself experienced sudden throttle while download such large file, im thinking whether is it a good idea to move to some other CDN services. For free, incapsula, or cheap cdn service, like FDCserver's (5USD/TB)

@Frisasky commented on GitHub (Jul 19, 2019): well i think maybe it has something do to with cloudflare, some user also report theres trouble downloading large file(1GB+) and myself experienced sudden throttle while download such large file, im thinking whether is it a good idea to move to some other CDN services. For free, incapsula, or cheap cdn service, like FDCserver's (5USD/TB)

kerem commented

2026-02-27 02:59:04 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Jul 19, 2019):

The failure was because the file didn't exist when developing a game. There is no error checking in place currently for failed curl downloads.

@dgibbs64 commented on GitHub (Jul 19, 2019): The failure was because the file didn't exist when developing a game. There is no error checking in place currently for failed curl downloads.

kerem commented

2026-02-27 02:59:04 +03:00

Author

Owner

@Bourne-ID commented on GitHub (Jul 19, 2019):

There's a few incidents where a command is expected to finish successfully, or error reporting doesn't retry/exit the script (tar extracts is another instance). We need to agree on an exit code or strategy when these happen...

@Bourne-ID commented on GitHub (Jul 19, 2019): There's a few incidents where a command is expected to finish successfully, or error reporting doesn't retry/exit the script (tar extracts is another instance). We need to agree on an exit code or strategy when these happen...

kerem commented

2026-02-27 02:59:04 +03:00

Author

Owner

@Claiyc commented on GitHub (Mar 23, 2022):

Is this still relevant?

@Claiyc commented on GitHub (Mar 23, 2022): Is this still relevant?