[GH-ISSUE #2302] Monitor function prevents the server from starting if it's in the process of starting #1736

Closed
opened 2026-02-27 02:58:47 +03:00 by kerem · 5 comments
Owner

Originally created by @haggbart on GitHub (Apr 24, 2019).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2302

User Story

As a user, I want the monitor function to work correctly so that it will kill the server if it's not responding.

Basic info

  • Distro: Debian 9
  • Game: Rust
  • Command: Monitor

Further Information

If the server is in the process of starting, monitor will force kill the process and cancel start.
This happens because query_gsquery.py tries to querry the game port, which will not respond until the server has started. It should querry using the rcon port, which will respond while starting.

To Reproduce

Steps to reproduce the behaviour:

  1. ./rustserver start
  2. ./rustserver monitor
  3. The script will kill the process, stopping the server from starting.
  4. See attachement.
    yUc7dzb

Expected behaviour

monitor function should kill the process if it's not responding

Originally created by @haggbart on GitHub (Apr 24, 2019). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2302 ## User Story As a user, I want the monitor function to work correctly so that it will kill the server if it's not responding. ## Basic info * Distro: Debian 9 * Game: Rust * Command: Monitor ## Further Information If the server is in the process of starting, monitor will force kill the process and cancel start. This happens because query_gsquery.py tries to querry the game port, which will not respond until the server has started. It should querry using the rcon port, which will respond while starting. ## To Reproduce Steps to reproduce the behaviour: 1. ./rustserver start 2. ./rustserver monitor 3. The script will kill the process, stopping the server from starting. 4. See attachement. ![yUc7dzb](https://user-images.githubusercontent.com/4412029/56646770-85e90a00-6680-11e9-9754-b9db03fb0f48.jpg) ## Expected behaviour monitor function should kill the process if it's not responding
Author
Owner

@dgibbs64 commented on GitHub (Apr 25, 2019):

I believe this is linked to another issue #2119 This is an issue I will look at addressing soon. Thanks for the detailed and accurate issue you raised.

<!-- gh-comment-id:486665753 --> @dgibbs64 commented on GitHub (Apr 25, 2019): I believe this is linked to another issue #2119 This is an issue I will look at addressing soon. Thanks for the detailed and accurate issue you raised.
Author
Owner

@kobalt-rustafied commented on GitHub (Jun 22, 2019):

@dgibbs64 Issue #2119 was closed and marked as fixed with v19.7.0. In our use case with rust servers, we are still having the exact same issue. Maybe I am misunderstanding but I thought the lock file should prevent the monitor from ever running a query until the query delay time has passed. In my experience, the query delay has no effect on it. I have also tried editing command_monitor.sh directly and adding in the query delay variable and it still had no effect on it.

<!-- gh-comment-id:504631460 --> @kobalt-rustafied commented on GitHub (Jun 22, 2019): @dgibbs64 Issue #2119 was closed and marked as fixed with v19.7.0. In our use case with rust servers, we are still having the exact same issue. Maybe I am misunderstanding but I thought the lock file should prevent the monitor from ever running a query until the query delay time has passed. In my experience, the query delay has no effect on it. I have also tried editing command_monitor.sh directly and adding in the query delay variable and it still had no effect on it.
Author
Owner

@kobalt-rustafied commented on GitHub (Jun 22, 2019):

@dgibbs64 I found the issue. In command_monitor.sh
if [ "$(cat "${rootdir}/${lockselfname}")" -lt "$(date "+%s" -d "${querydelay} mins ago")" ]; then
needs to be chnaged to
if [ "$(cat "${rootdir}/${lockselfname}")" -gt "$(date "+%s" -d "${querydelay} mins ago")" ]; then

This has fixed my issue, I hope it can help anyone else who may have the same issue.

<!-- gh-comment-id:504633159 --> @kobalt-rustafied commented on GitHub (Jun 22, 2019): @dgibbs64 I found the issue. In command_monitor.sh if [ "$(cat "${rootdir}/${lockselfname}")" -lt "$(date "+%s" -d "${querydelay} mins ago")" ]; then needs to be chnaged to if [ "$(cat "${rootdir}/${lockselfname}")" -**g**t "$(date "+%s" -d "${querydelay} mins ago")" ]; then This has fixed my issue, I hope it can help anyone else who may have the same issue.
Author
Owner

@h3o66 commented on GitHub (Jun 22, 2019):

just created a pr to fix this

<!-- gh-comment-id:504667803 --> @h3o66 commented on GitHub (Jun 22, 2019): just created a pr to fix this
Author
Owner

@github-actions[bot] commented on GitHub (Dec 25, 2020):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:751133173 --> @github-actions[bot] commented on GitHub (Dec 25, 2020): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#1736
No description provided.