[GH-ISSUE #2068] Server should be stopped during mods-update #1609

Open
opened 2026-02-27 02:58:06 +03:00 by kerem · 4 comments
Owner

Originally created by @borzaka on GitHub (Oct 31, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2068

From the SourceMod Wiki: Upgrading SourceMod

Ensure your game server is completely stopped and not running as you cannot update some files while they are still in use.

Running: ./csgoserver mods-update

csgoserver@dellserver:~$ ./csgoserver mods-update
[ INFO ] Mods Update csgoserver: Update addons/mods: 2 addons/mods will be updated
        * MetaMod (retain common custom files)
        * SourceMod (retain common custom files)

==> Updating MetaMod
creating mod download directory /home/csgoserver/lgsm/mods/tmp...OK
######################################################################## 100.0%it966-linux.tar.gz...
OK
extracting mmsource-1.10.7-git966-linux.tar.gz...OK
the following files/directories will be preserved:
        * serverfiles/addons/metamod/metaplugins.ini
building metamod-files.txt...OK
copying MetaMod to /home/csgoserver/serverfiles/csgo...OK
tidy up metamod-files.txt...OK
clearing mod download directory /home/csgoserver/lgsm/mods/tmp...OK

==> Updating SourceMod
creating mod download directory /home/csgoserver/lgsm/mods/tmp...OK
######################################################################## 100.0%git6260-linux.tar.gz...
OK
extracting sourcemod-1.9.0-git6260-linux.tar.gz...OK
the following files/directories will be preserved:
        * serverfiles/cfg
        * serverfiles/addons/sourcemod/configs
building sourcemod-files.txt...OK
copying SourceMod to /home/csgoserver/serverfiles/csgo...OK
tidy up sourcemod-files.txt...OK
clearing mod download directory /home/csgoserver/lgsm/mods/tmp...OK

[  OK  ] Mods Update csgoserver: Mods update complete

Expected behaviour
A server should be stopped during mods-update, and restart after it's finished.

Additional context
mods-update is updating the mods regardless the version installed. It's updating even an updated version as well.

Originally created by @borzaka on GitHub (Oct 31, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2068 From the SourceMod Wiki: [Upgrading SourceMod](https://wiki.alliedmods.net/Upgrading_SourceMod) > Ensure your game server is completely stopped and not running as you cannot update some files while they are still in use. Running: `./csgoserver mods-update` ``` csgoserver@dellserver:~$ ./csgoserver mods-update [ INFO ] Mods Update csgoserver: Update addons/mods: 2 addons/mods will be updated * MetaMod (retain common custom files) * SourceMod (retain common custom files) ==> Updating MetaMod creating mod download directory /home/csgoserver/lgsm/mods/tmp...OK ######################################################################## 100.0%it966-linux.tar.gz... OK extracting mmsource-1.10.7-git966-linux.tar.gz...OK the following files/directories will be preserved: * serverfiles/addons/metamod/metaplugins.ini building metamod-files.txt...OK copying MetaMod to /home/csgoserver/serverfiles/csgo...OK tidy up metamod-files.txt...OK clearing mod download directory /home/csgoserver/lgsm/mods/tmp...OK ==> Updating SourceMod creating mod download directory /home/csgoserver/lgsm/mods/tmp...OK ######################################################################## 100.0%git6260-linux.tar.gz... OK extracting sourcemod-1.9.0-git6260-linux.tar.gz...OK the following files/directories will be preserved: * serverfiles/cfg * serverfiles/addons/sourcemod/configs building sourcemod-files.txt...OK copying SourceMod to /home/csgoserver/serverfiles/csgo...OK tidy up sourcemod-files.txt...OK clearing mod download directory /home/csgoserver/lgsm/mods/tmp...OK [ OK ] Mods Update csgoserver: Mods update complete ``` **Expected behaviour** A server should be stopped during mods-update, and restart after it's finished. **Additional context** `mods-update` is updating the mods regardless the version installed. It's updating even an updated version as well.
Author
Owner

@dgibbs64 commented on GitHub (Nov 1, 2018):

From what I remember there was no way to track the versions of the mods to only update when required. But that might of changed since. This issue will need to be investigated

<!-- gh-comment-id:434992779 --> @dgibbs64 commented on GitHub (Nov 1, 2018): From what I remember there was no way to track the versions of the mods to only update when required. But that might of changed since. This issue will need to be investigated
Author
Owner

@0xlord commented on GitHub (Nov 4, 2018):

FLAX, an ARMA mod/server tool checks the changelog and/or the last update time to determine if a mod has been updated. This would require a way to keep track when a mod was last updated. This could be done by a simple text/config file in which is written what Workshop id was updated for the last time:

id.time = actual workshop version --> do nothing
id.time = not available --> download and install (as new mod being added)
id.time = older than last workshop version --> download and update

<!-- gh-comment-id:435680692 --> @0xlord commented on GitHub (Nov 4, 2018): [FLAX](https://github.com/alec-hs/Flaxs-Arma-Server-Tool), an ARMA mod/server tool checks the changelog and/or the last update time to determine if a mod has been updated. This would require a way to keep track when a mod was last updated. This could be done by a simple text/config file in which is written what Workshop id was updated for the last time: id.time = actual workshop version --> do nothing id.time = not available --> download and install (as new mod being added) id.time = older than last workshop version --> download and update
Author
Owner

@borzaka commented on GitHub (Nov 18, 2018):

The issue is about that any source based game server should be stopped during mods update/install/remove and restarted after the update/install/remove is finished (if it was stopped before).

BTW, you can check the latest version filename:

Maybe storing these filenames, and compare it could help not running an update on an already up to date mod.

<!-- gh-comment-id:439695038 --> @borzaka commented on GitHub (Nov 18, 2018): The issue is about that any source based game server should be stopped during mods update/install/remove and restarted after the update/install/remove is finished (if it was stopped before). BTW, you can check the latest version filename: - Metamod: [https://mms.alliedmods.net/mmsdrop/1.10/mmsource-latest-linux](https://mms.alliedmods.net/mmsdrop/1.10/mmsource-latest-linux) - Sourcemod: [https://sm.alliedmods.net/smdrop/1.9/sourcemod-latest-linux](https://sm.alliedmods.net/smdrop/1.9/sourcemod-latest-linux) Maybe storing these filenames, and compare it could help not running an update on an already up to date mod. <blockquote></blockquote> <blockquote></blockquote>
Author
Owner

@dgibbs64 commented on GitHub (Dec 3, 2018):

Will update to stop the server when a mods update is started

<!-- gh-comment-id:443908389 --> @dgibbs64 commented on GitHub (Dec 3, 2018): Will update to stop the server when a mods update is started
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#1609
No description provided.