[GH-ISSUE #1969] Poor missing dependency handling #1546

New issue

Closed

opened 2026-02-27 02:57:44 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 02:57:44 +03:00

Owner

Originally created by @transelement on GitHub (Jul 28, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1969

This issue was brought up and conveniently ignored in #1966 however still remains.

When a missing dependency is identified by the installer it should STOP or PROMPT the user to resolve the error at hand, rather than continuing the install leaving the missing dependency 5 pages in scrollback.

As it stands the following flashes by the terminal:

[ERROR ] Install $SERVER: Checking dependencies: missing: $DEPENDENCY 

Warning! $USER does not have sudo access. Manually install dependencies.
        sudo dpkg --add-architecture i386; sudo apt update; sudo apt install $DEPENDENCY

Which "isn't enough."

Notwithstanding the fact that you should never recommend that a game server user have sudo rights to apt to install anything.

Originally created by @transelement on GitHub (Jul 28, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1969 This issue was brought up and conveniently ignored in #1966 however still remains. When a missing dependency is identified by the installer it should STOP or PROMPT the user to resolve the error at hand, rather than continuing the install leaving the missing dependency 5 pages in scrollback. As it stands the following flashes by the terminal: ``` [ERROR ] Install $SERVER: Checking dependencies: missing: $DEPENDENCY Warning! $USER does not have sudo access. Manually install dependencies. sudo dpkg --add-architecture i386; sudo apt update; sudo apt install $DEPENDENCY ``` Which "isn't enough." Notwithstanding the fact that you should never recommend that a game server user have sudo rights to apt to install _anything_.

kerem

2026-02-27 02:57:44 +03:00

closed this issue
added the
type: refactor

command: install

info: dependency
labels

kerem commented

2026-02-27 02:57:45 +03:00

Author

Owner

@UltimateByte commented on GitHub (Jul 28, 2018):

I agree with that, sudo should not be recommended imo.
Also agree that the process should stop if a missing dependency is noticed.

I think a major refacor of the dependency check function would be welcome, possibly with arrays just like core_getopt.sh does, which would help handling cases like this.
Arrays would contain at least:

Which package name for which distro
Which package check for which distro
Which package is critical or not and for which command
What to do if missing package is found

@UltimateByte commented on GitHub (Jul 28, 2018): I agree with that, sudo should not be recommended imo. Also agree that the process should stop if a missing dependency is noticed. I think a major refacor of the dependency check function would be welcome, possibly with arrays just like core_getopt.sh does, which would help handling cases like this. Arrays would contain at least: - Which package name for which distro - Which package check for which distro - Which package is critical or not and for which command - What to do if missing package is found

kerem commented

2026-02-27 02:57:45 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Nov 23, 2018):

Dependency checker now stops if dependencies for SteamCMD are missing. Preventing SteamCMD from failing to run.

Also if you run ./gameserver install as root it will now install dependencies only.

I am reluctant to prevent server installation if all dependencies are not met as there are sometimes issues with dependency detection. However a review of this would be a good idea

@dgibbs64 commented on GitHub (Nov 23, 2018): Dependency checker now stops if dependencies for SteamCMD are missing. Preventing SteamCMD from failing to run. Also if you run `./gameserver install` as root it will now install dependencies only. I am reluctant to prevent server installation if all dependencies are not met as there are sometimes issues with dependency detection. However a review of this would be a good idea

kerem commented

2026-02-27 02:57:45 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Mar 9, 2020):

A missing dependency is highlighted every time a server starts and various refactoring has been completed that should have improved dependency checking. I will close this and it can be re-raised if more work is required

@dgibbs64 commented on GitHub (Mar 9, 2020): A missing dependency is highlighted every time a server starts and various refactoring has been completed that should have improved dependency checking. I will close this and it can be re-raised if more work is required

kerem commented

2026-02-27 02:57:45 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Mar 14, 2021):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (Mar 14, 2021): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.