[GH-ISSUE #1912] Steam API key is visible on postdetails output #1506

Closed
opened 2026-02-27 02:57:29 +03:00 by kerem · 12 comments
Owner

Originally created by @UltimateByte on GitHub (Jun 3, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1912

Originally assigned to: @dgibbs64 on GitHub.

This issue is critical, needs fix ASAP.

Originally created by @UltimateByte on GitHub (Jun 3, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1912 Originally assigned to: @dgibbs64 on GitHub. This issue is critical, needs fix ASAP.
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

@UltimateByte whereabouts is it visible?

<!-- gh-comment-id:397027721 --> @dgibbs64 commented on GitHub (Jun 13, 2018): @UltimateByte whereabouts is it visible?
Author
Owner

@UltimateByte commented on GitHub (Jun 13, 2018):

In my gmodserver it is visible.
Actually, that's weird, because in an attempt to change the authkey to show you, it didn't change in the postdetails link, but it changed in regular details. So I don't know where it comes from. Any idea?

  • My common.cfg is empty
  • Script is up to date
  • The variable only appears once
<!-- gh-comment-id:397049028 --> @UltimateByte commented on GitHub (Jun 13, 2018): In my gmodserver it is visible. Actually, that's weird, because in an attempt to change the authkey to show you, it didn't change in the postdetails link, but it changed in regular details. So I don't know where it comes from. Any idea? * My common.cfg is empty * Script is up to date * The variable only appears once
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

I have no idea

<!-- gh-comment-id:397053020 --> @dgibbs64 commented on GitHub (Jun 13, 2018): I have no idea
Author
Owner

@UltimateByte commented on GitHub (Jun 13, 2018):

I kind of reproduced the issue.
I had to remove the postdetails log in log/script/gmodserver-postdetails.log for it to update, so I might have found a second bug, or related bug.

Output: https://hastebin.com/ciqokikolo

<!-- gh-comment-id:397053029 --> @UltimateByte commented on GitHub (Jun 13, 2018): I kind of reproduced the issue. I had to remove the postdetails log in log/script/gmodserver-postdetails.log for it to update, so I might have found a second bug, or related bug. Output: https://hastebin.com/ciqokikolo <blockquote><div><strong><a href="https://hastebin.com/ciqokikolo">hastebin</a></strong></div></blockquote>
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

Awesome I can work with that :). Please could to try to replicate the other bug you came across and raise it if required.

<!-- gh-comment-id:397054748 --> @dgibbs64 commented on GitHub (Jun 13, 2018): Awesome I can work with that :). Please could to try to replicate the other bug you came across and raise it if required.
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

This has just opened a can or worms as the way workshop vars are setup over several games are different

<!-- gh-comment-id:397056949 --> @dgibbs64 commented on GitHub (Jun 13, 2018): This has just opened a can or worms as the way workshop vars are setup over several games are different
Author
Owner

@UltimateByte commented on GitHub (Jun 13, 2018):

Fix for authkey:
Add there: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_messages.sh#L1194

		if [ -n "${workshopauth}" ]; then
			workshopauth="********"
		fi
<!-- gh-comment-id:397081152 --> @UltimateByte commented on GitHub (Jun 13, 2018): Fix for authkey: Add there: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_messages.sh#L1194 ```bash if [ -n "${workshopauth}" ]; then workshopauth="********" fi ```
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

thanks, I'm working on it. Also now hiding gslt and fixing the issue with pd not updating

<!-- gh-comment-id:397083564 --> @dgibbs64 commented on GitHub (Jun 13, 2018): thanks, I'm working on it. Also now hiding gslt and fixing the issue with pd not updating
Author
Owner

@UltimateByte commented on GitHub (Jun 13, 2018):

yw
I couldn't find why it's not updating. I need some rest :)

<!-- gh-comment-id:397083802 --> @UltimateByte commented on GitHub (Jun 13, 2018): yw I couldn't find why it's not updating. I need some rest :)
Author
Owner

@dgibbs64 commented on GitHub (Jun 13, 2018):

it now just removes the log if it exists. All issues now resolved for release

<!-- gh-comment-id:397085729 --> @dgibbs64 commented on GitHub (Jun 13, 2018): it now just removes the log if it exists. All issues now resolved for release
Author
Owner

@UltimateByte commented on GitHub (Jun 13, 2018):

That doesn't explain why the > redirection doesn't overwrite the log content, but if that does the trick, that's the most important.

<!-- gh-comment-id:397086085 --> @UltimateByte commented on GitHub (Jun 13, 2018): That doesn't explain why the `>` redirection doesn't overwrite the log content, but if that does the trick, that's the most important.
Author
Owner

@lock[bot] commented on GitHub (Jun 16, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:502412688 --> @lock[bot] commented on GitHub (Jun 16, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#1506
No description provided.