[GH-ISSUE #1893] appid not being forwarded to the command_validate script from the "main menu" #1486

Closed
opened 2026-02-27 02:57:23 +03:00 by kerem · 12 comments
Owner

Originally created by @draakuns on GitHub (May 4, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1893

Hi,

I just noticed (but I really don't know where it started or whether I am doing something wrong) that command_validate.sh function gets an empty string for "appid" variable, which should be provided from _default.cfg file as far as I can see.

the main command is:
${unbuffer} ./steamcmd.sh +login "${steamuser}" "${steampass}" +force_install_dir "${serverfiles}" +app_update "${appid}" ${branch} validate +quit | tee -a "${lgsmlog}"

which debugging gets:
./steamcmd.sh +login myuser mypassword +force_install_dir /home/steamsrv/arma3/serverfiles +app_update '' validate +quit
I tried too with my insurgency server and I get the same result.
So the validation is never done for the desired appid.

Best regards,
Draakuns.

Originally created by @draakuns on GitHub (May 4, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1893 Hi, I just noticed (but I really don't know where it started or whether I am doing something wrong) that command_validate.sh function gets an empty string for "appid" variable, which should be provided from _default.cfg file as far as I can see. the main command is: ` ${unbuffer} ./steamcmd.sh +login "${steamuser}" "${steampass}" +force_install_dir "${serverfiles}" +app_update "${appid}" ${branch} validate +quit | tee -a "${lgsmlog}"` which debugging gets: `./steamcmd.sh +login myuser mypassword +force_install_dir /home/steamsrv/arma3/serverfiles +app_update '' validate +quit ` I tried too with my insurgency server and I get the same result. So the validation is never done for the desired appid. Best regards, Draakuns.
Author
Owner

@UltimateByte commented on GitHub (May 5, 2018):

Hi,

Rule N°1) Read rules

https://linuxgsm.com/support/#guide

I see no reason why this would be a global LinuxGSM issue, so closing for now.

LinuxGSM
There are various ways to get help and support with LinuxGSM. Including wiki, steam group and discord
<!-- gh-comment-id:386764235 --> @UltimateByte commented on GitHub (May 5, 2018): Hi, Rule N°1) Read rules https://linuxgsm.com/support/#guide I see no reason why this would be a global LinuxGSM issue, so closing for now. <blockquote><img src="http://gameservermanagers.com/wp-content/uploads/2015/08/lgsm-full-dark.png" width="48" align="right"><div>LinuxGSM</div><div><strong><a href="https://linuxgsm.com/support/">Support – LinuxGSM</a></strong></div><div>There are various ways to get help and support with LinuxGSM. Including wiki, steam group and discord</div></blockquote>
Author
Owner

@draakuns commented on GitHub (May 7, 2018):

Well, I don't understand your statement, as I am trying to issue a problem in your global bash scripts. If I explain that the appid is lost somewhere in the execution of both servers (arma3 and insurgency), then the problem should rely on the LGSM layer.
I will add the info about OS whenever possible.

<!-- gh-comment-id:386991108 --> @draakuns commented on GitHub (May 7, 2018): Well, I don't understand your statement, as I am trying to issue a problem in your global bash scripts. If I explain that the appid is lost somewhere in the execution of both servers (arma3 and insurgency), then the problem *should* rely on the LGSM layer. I will add the info about OS whenever possible.
Author
Owner

@draakuns commented on GitHub (May 7, 2018):

Gameserver: As I already wrote, Arma3 & Insurgency, which fail in the same way.

Postdetails: https://pastebin.com/xwB3mxe4

Pastebin
<!-- gh-comment-id:386993556 --> @draakuns commented on GitHub (May 7, 2018): Gameserver: As I already wrote, Arma3 & Insurgency, which fail in the same way. Postdetails: https://pastebin.com/xwB3mxe4 <blockquote><img src="https://pastebin.com/i/facebook.png" width="48" align="right"><div>Pastebin</div><div><strong><a href="https://pastebin.com/xwB3mxe4">Missing appid - Pastebin.com</a></strong></div></blockquote>
Author
Owner

@draakuns commented on GitHub (May 7, 2018):

exec dev-debug-function-order.log: https://pastebin.com/NbsHeHxp

exec dev-debug.log: https://pastebin.com/nFmM1AzX

Let me know if need anything else.

Pastebin
Pastebin
<!-- gh-comment-id:386997832 --> @draakuns commented on GitHub (May 7, 2018): exec dev-debug-function-order.log: https://pastebin.com/NbsHeHxp exec dev-debug.log: https://pastebin.com/nFmM1AzX Let me know if need anything else. <blockquote><img src="https://pastebin.com/i/facebook.png" width="48" align="right"><div>Pastebin</div><div><strong><a href="https://pastebin.com/NbsHeHxp">appid -- dev-debug-function-order.log - Pastebin.com</a></strong></div></blockquote> <blockquote><img src="https://pastebin.com/i/facebook.png" width="48" align="right"><div>Pastebin</div><div><strong><a href="https://pastebin.com/nFmM1AzX">Possible Spam Detected</a></strong></div></blockquote>
Author
Owner

@UltimateByte commented on GitHub (May 7, 2018):

Better. Trying to reproduce.

Any reason why you posted the issue manually over using postdetails command?

<!-- gh-comment-id:387224647 --> @UltimateByte commented on GitHub (May 7, 2018): Better. Trying to reproduce. Any reason why you posted the issue manually over using postdetails command?
Author
Owner

@UltimateByte commented on GitHub (May 7, 2018):

Confirmed. For once it's not a false alert, thanks for reporting.

Sample log:

ultimatebyte@gaben:~/serverfiles/insurgency$ rm insurgency_sound_003.vpk insurgency_sound_004.vpk
ultimatebyte@gaben:~/serverfiles/insurgency$ cd
ultimatebyte@gaben:~$ ./insserver v
[ .... ] Validate insserver: Validating files: SteamCMD
        * Validating may overwrite some customised files.
        * https://developer.valvesoftware.com/wiki/SteamCMD#Validate
Redirecting stderr to '/home/ultimatebyte/Steam/logs/stderr.txt'
[  0%] Checking for available updates...
[----] Verifying installation...
Steam Console Client (c) Valve Corporation
-- type 'quit' to exit --
Loading Steam API...OK.

Connecting anonymously to Steam Public...Logged in OK
Waiting for user info...OK
[  OK  ] Validate insserver: Validating files: SteamCMD

Checking deeper to diagnose this.

<!-- gh-comment-id:387226586 --> @UltimateByte commented on GitHub (May 7, 2018): Confirmed. For once it's not a false alert, thanks for reporting. Sample log: ``` ultimatebyte@gaben:~/serverfiles/insurgency$ rm insurgency_sound_003.vpk insurgency_sound_004.vpk ultimatebyte@gaben:~/serverfiles/insurgency$ cd ultimatebyte@gaben:~$ ./insserver v [ .... ] Validate insserver: Validating files: SteamCMD * Validating may overwrite some customised files. * https://developer.valvesoftware.com/wiki/SteamCMD#Validate Redirecting stderr to '/home/ultimatebyte/Steam/logs/stderr.txt' [ 0%] Checking for available updates... [----] Verifying installation... Steam Console Client (c) Valve Corporation -- type 'quit' to exit -- Loading Steam API...OK. Connecting anonymously to Steam Public...Logged in OK Waiting for user info...OK [ OK ] Validate insserver: Validating files: SteamCMD ``` Checking deeper to diagnose this.
Author
Owner

@UltimateByte commented on GitHub (May 7, 2018):

This is to blame.
github.com/GameServerManagers/LinuxGSM@26b717b0f8 (diff-44346d4839)
Not sure why it's here yet but that's the issue. It rewrites appid with an unset variable.

<!-- gh-comment-id:387230551 --> @UltimateByte commented on GitHub (May 7, 2018): This is to blame. https://github.com/GameServerManagers/LinuxGSM/commit/26b717b0f80795a6a45bf1b0fb48c1beda662e2c#diff-44346d483951ed5dfa13b6f06008a3a0 Not sure why it's here yet but that's the issue. It rewrites appid with an unset variable.
Author
Owner

@UltimateByte commented on GitHub (May 7, 2018):

Fixed.

Thanks a lot for sharing your details after my 1st post and congrats for not being discouraged.
Please update your linuxgsm with ./gameserver ul to check if it resolved the issue for you as well.

Cheers 🍻

<!-- gh-comment-id:387235468 --> @UltimateByte commented on GitHub (May 7, 2018): Fixed. Thanks a lot for sharing your details after my 1st post and congrats for not being discouraged. Please update your linuxgsm with `./gameserver ul` to check if it resolved the issue for you as well. Cheers 🍻
Author
Owner

@draakuns commented on GitHub (May 8, 2018):

Hey!

I did the explanation manually instead of PD because it felt more clear, but maybe it wasnt :)

To me, it seems it was a separate function beeing feeded arguments from commandline, and at some point it was merged into your main... Who knows?
Also, IMO there's some guilt to blame to steamcmd for not parsing well things, or complaining about the lack of appid on their validation...

It is fixed on both servers I have ;)

Happy to hear that it has been fixed so quickly, thanks!

Dont worry about the 1st post... I can understand the monster that sometimes approaches in the form of an issue from inexpert hands... Its always good to have guidelines for all of us.

BR
Draakuns

<!-- gh-comment-id:387336993 --> @draakuns commented on GitHub (May 8, 2018): Hey! I did the explanation manually instead of PD because it felt more clear, but maybe it wasnt :) To me, it seems it was a separate function beeing feeded arguments from commandline, and at some point it was merged into your main... Who knows? Also, IMO there's some guilt to blame to steamcmd for not parsing well things, or complaining about the lack of appid on their validation... It is fixed on both servers I have ;) Happy to hear that it has been fixed so quickly, thanks! Dont worry about the 1st post... I can understand the monster that sometimes approaches in the form of an issue from inexpert hands... Its always good to have guidelines for all of us. BR Draakuns
Author
Owner

@UltimateByte commented on GitHub (May 8, 2018):

Thanks for the feedback! Glad it was just that to fix :p

I believe it was just a programming mistake because I've never seen the appid being passed as a function argument. Maybe it was in the process of making a universal installer, which is an idea we had for some time now.

Yes, we have so many unhelpful posts with isolated issues that it's sometimes harder to notice when it's a global one at first glance. When experiencing a bug, postdetails is the bare minimum info to provide, and you went further with dev-debug outputs which gained me some time: with functions order, we know where to look, with the log I was able to see that appid was set to an empty var at some point :)

<!-- gh-comment-id:387483410 --> @UltimateByte commented on GitHub (May 8, 2018): Thanks for the feedback! Glad it was just that to fix :p I believe it was just a programming mistake because I've never seen the appid being passed as a function argument. Maybe it was in the process of making a universal installer, which is an idea we had for some time now. Yes, we have so many unhelpful posts with isolated issues that it's sometimes harder to notice when it's a global one at first glance. When experiencing a bug, postdetails is the bare minimum info to provide, and you went further with dev-debug outputs which gained me some time: with functions order, we know where to look, with the log I was able to see that appid was set to an empty var at some point :)
Author
Owner

@draakuns commented on GitHub (May 9, 2018):

Happy to hear. 100% sure you will hear again from me ;)

Good job you did here!
Draakuns

<!-- gh-comment-id:387658752 --> @draakuns commented on GitHub (May 9, 2018): Happy to hear. 100% sure you will hear again from me ;) Good job you did here! Draakuns
Author
Owner

@lock[bot] commented on GitHub (May 9, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:490813971 --> @lock[bot] commented on GitHub (May 9, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#1486
No description provided.