[GH-ISSUE #1871] Alter if statements with -z to -v #1468

New issue

Closed

opened 2026-02-27 02:57:17 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 02:57:17 +03:00

Owner

Originally created by @dgibbs64 on GitHub (Apr 10, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1871

Been running a test on if statements for Travis CI. The if statement was not working correctly for the usual -z to tell if a var exists. I have learnt of a better way to identity is a var is empty by using -v this has existing since bash 4.2 which is all supported Distros apart from CentOS 6 (really shouldn't be using this anymore). If this alternation was made support for CentOS 6 will have to end. For now I will use this on the travis tests. but in future I think this best practice should be adopted across the board

   -v varname
          True if the shell variable varname is set (has been assigned a value).
   -z string
          True if the length of string is zero.

Originally created by @dgibbs64 on GitHub (Apr 10, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1871 Been running a test on if statements for Travis CI. The if statement was not working correctly for the usual -z to tell if a var exists. I have learnt of a better way to identity is a var is empty by using -v this has existing since bash 4.2 which is all supported Distros apart from CentOS 6 (really shouldn't be using this anymore). If this alternation was made support for CentOS 6 will have to end. For now I will use this on the travis tests. but in future I think this best practice should be adopted across the board -v varname True if the shell variable varname is set (has been assigned a value). -z string True if the length of string is zero.

kerem

2026-02-27 02:57:17 +03:00

closed this issue
added the
outcome: wontfix

type: refactor
labels

kerem commented

2026-02-27 02:57:18 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Feb 23, 2019):

Must ensure that this only changes for checking that a var exists. -z is still required in places

@dgibbs64 commented on GitHub (Feb 23, 2019): Must ensure that this only changes for checking that a var exists. -z is still required in places

kerem commented

2026-02-27 02:57:18 +03:00

Author

Owner

@dgibbs64 commented on GitHub (May 9, 2019):

-z is not always reacting the way i would expect.

@dgibbs64 commented on GitHub (May 9, 2019): -z is not always reacting the way i would expect.

kerem commented

2026-02-27 02:57:18 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Jun 12, 2019):

I will close this currently as not an urgent change and lots of testing required. Will be mindful of this new option moving forward

@dgibbs64 commented on GitHub (Jun 12, 2019): I will close this currently as not an urgent change and lots of testing required. Will be mindful of this new option moving forward

kerem commented

2026-02-27 02:57:18 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 25, 2020):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (Dec 25, 2020): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.