starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 06:05:57 +03:00

[GH-ISSUE #1869] Factorio Update Compares Current Version Number to the Word "stable" #1467

New issue

Closed

opened 2026-02-27 02:57:16 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 02:57:16 +03:00

Owner

Originally created by @fanuch on GitHub (Apr 6, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1869

Updating Factorio results in an expected numerical version number is giving the word "stable"

Line 80 of lgsm/functions/update_factorio.sh:

availablebuild=$(curl -s https://www.factorio.com/download-headless | grep 'headless/linux64' | head -n 1 | grep -oP '(?<=get-download/).*?(?=/)')

Curl results in the word stable which gives this error on update:

/home/fctrserver/lgsm/functions/update_factorio.sh: line 104: [: : integer expression expected

as it compares the latest version to the current version as integers

I propose changing the grep 'headless/linux64' to grep -e 'get-download\/0\..*' which will grab the topmost version number, as the site presents versions in descending order.

This would make the following command, which has been tested and working on my update from 0.1540 to 0.16.36:

availablebuild=$(curl -s https://www.factorio.com/download-headless | grep -e 'get-download\/0\..*' | head -n 1 | grep -oP '(?<=get-download/).*?(?=/)')

Limitation of my fix is if Factorio moves away from 0.x to 1.x release in the future.

If that's okay with you, I can do a PR with that fix.

Originally created by @fanuch on GitHub (Apr 6, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1869 Updating Factorio results in an expected numerical version number is giving the word "**stable**" Line 80 of `lgsm/functions/update_factorio.sh`: ``` availablebuild=$(curl -s https://www.factorio.com/download-headless | grep 'headless/linux64' | head -n 1 | grep -oP '(?<=get-download/).*?(?=/)') ``` Curl results in the word `stable` which gives this error on update: ``` /home/fctrserver/lgsm/functions/update_factorio.sh: line 104: [: : integer expression expected ``` as it compares the latest version to the current version as integers I propose changing the `grep 'headless/linux64' ` to `grep -e 'get-download\/0\..*'` which will grab the topmost version number, as the site presents versions in descending order. This would make the following command, which has been tested and working on my update from 0.1540 to 0.16.36: ``` availablebuild=$(curl -s https://www.factorio.com/download-headless | grep -e 'get-download\/0\..*' | head -n 1 | grep -oP '(?<=get-download/).*?(?=/)') ``` Limitation of my fix is if Factorio moves away from 0.x to 1.x release in the future. If that's okay with you, I can do a PR with that fix.

kerem

2026-02-27 02:57:16 +03:00

closed this issue
added the
type: bug

game: Factorio
labels

kerem commented

2026-02-27 02:57:17 +03:00

Author

Owner

@UltimateByte commented on GitHub (Apr 6, 2018):

This is supposed to be hotfixed already, did you update your LinuxGSM ?

@UltimateByte commented on GitHub (Apr 6, 2018): This is supposed to be hotfixed already, did you update your LinuxGSM ?

kerem commented

2026-02-27 02:57:17 +03:00

Author

Owner

@UltimateByte commented on GitHub (Apr 6, 2018):

Ref: #1864

@UltimateByte commented on GitHub (Apr 6, 2018): Ref: #1864

kerem commented

2026-02-27 02:57:17 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Apr 6, 2018):

If you are on the latest version of LinuxGSM feel free to create a PR :)

@dgibbs64 commented on GitHub (Apr 6, 2018): If you are on the latest version of LinuxGSM feel free to create a PR :)

kerem commented

2026-02-27 02:57:17 +03:00

Author

Owner

@no-response[bot] commented on GitHub (Jul 18, 2018):

This issue has been automatically closed because there has been no response to this issue and is now stale.

@no-response[bot] commented on GitHub (Jul 18, 2018): This issue has been automatically closed because there has been no response to this issue and is now stale.

kerem commented

2026-02-27 02:57:17 +03:00

Author

Owner

@lock[bot] commented on GitHub (Jul 18, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Jul 18, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.