starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 14:15:59 +03:00

[GH-ISSUE #1836] Add override to run linuxgsm.sh as root inside dedicated container isolations #1439

New issue

Closed

opened 2026-02-27 02:57:07 +03:00 by kerem · 6 comments

kerem commented

2026-02-27 02:57:07 +03:00

Owner

Originally created by @Astaelan on GitHub (Mar 10, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1836

As the title suggests, the linuxgsm.sh script should have a command-line parameter allowing to override the root checks and run the script as root.
When using container isolation like Docker it only serves to complicate the image build by requiring a diff patch processed in the build to ignore the root checks or adding the files core_functions.sh and check_root.sh to bypass which is messier with artifacts.

This also requires that the script it downloads for a specific game also be adjusted to avoid root checks.

Originally created by @Astaelan on GitHub (Mar 10, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1836 As the title suggests, the linuxgsm.sh script should have a command-line parameter allowing to override the root checks and run the script as root. When using container isolation like Docker it only serves to complicate the image build by requiring a diff patch processed in the build to ignore the root checks or adding the files core_functions.sh and check_root.sh to bypass which is messier with artifacts. This also requires that the script it downloads for a specific game also be adjusted to avoid root checks.

kerem closed this issue

2026-02-27 02:57:07 +03:00

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@UltimateByte commented on GitHub (Mar 19, 2018):

Hi,

Well, I'm not so sure about this one. Is it that hard to run LinuxGSM as a user in a container? (not using them so...)
Containers are unsupported at the moment, so maybe this is something to consider if they become supported at some point.

Whatever the case, it sounds like a bad idea to run any game server as root.

@UltimateByte commented on GitHub (Mar 19, 2018): Hi, Well, I'm not so sure about this one. Is it that hard to run LinuxGSM as a user in a container? (not using them so...) Containers are unsupported at the moment, so maybe this is something to consider if they become supported at some point. Whatever the case, it sounds like a bad idea to run any game server as root.

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@Astaelan commented on GitHub (Mar 19, 2018):

It is possible, but it's not the usual configuration with docker containers because it just adds extra work in building the image with extra artifacts, to an already isolated environment.
Whether root or not, your limited to changes in the container, to files that the user it ran under would need anyway.
I'm not proposing that this be the default, but a simple parameter to disable the checks would be beneficial whether it's "ideal" or not.

@Astaelan commented on GitHub (Mar 19, 2018): It is possible, but it's not the usual configuration with docker containers because it just adds extra work in building the image with extra artifacts, to an already isolated environment. Whether root or not, your limited to changes in the container, to files that the user it ran under would need anyway. I'm not proposing that this be the default, but a simple parameter to disable the checks would be beneficial whether it's "ideal" or not.

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@UltimateByte commented on GitHub (Mar 19, 2018):

Well, I think it would give bad ideas to noobs having this as an option. But since you know what you're doing, you can just edit these lines to bypass the check for LinuxGSM (should be enough, though I'm not 100% sure since I didn't test):
https://github.com/GameServerManagers/LinuxGSM/blob/master/linuxgsm.sh#L257-L266
And this file for game servers:
https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/check_root.sh

@UltimateByte commented on GitHub (Mar 19, 2018): Well, I think it would give bad ideas to noobs having this as an option. But since you know what you're doing, you can just edit these lines to bypass the check for LinuxGSM (should be enough, though I'm not 100% sure since I didn't test): https://github.com/GameServerManagers/LinuxGSM/blob/master/linuxgsm.sh#L257-L266 And this file for game servers: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/check_root.sh

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@Astaelan commented on GitHub (Mar 20, 2018):

I had a big long rant about how people should be smarter if they're going to administrate systems, and how I don't like being chopped off at the knees because "noobs might use it". Suffice to say I see resistance to a very basic, unobtrusive feature request. This spells EOL on this product, so thanks for your time, I'll move on.

@Astaelan commented on GitHub (Mar 20, 2018): I had a big long rant about how people should be smarter if they're going to administrate systems, and how I don't like being chopped off at the knees because "noobs might use it". Suffice to say I see resistance to a very basic, unobtrusive feature request. This spells EOL on this product, so thanks for your time, I'll move on.

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@UltimateByte commented on GitHub (Mar 20, 2018):

Says the dude who won't bother creating and using a user on his container. We had a hard time teaching people that root should be used cautiously, not to waste all these efforts with one nuts feature.

BTW
https://github.com/GameServerManagers/LinuxGSM-docker

@UltimateByte commented on GitHub (Mar 20, 2018): Says the dude who won't bother creating and using a user on his container. We had a hard time teaching people that root should be used cautiously, not to waste all these efforts with one nuts feature. BTW https://github.com/GameServerManagers/LinuxGSM-docker

kerem commented

2026-02-27 02:57:08 +03:00

Author

Owner

@lock[bot] commented on GitHub (Mar 20, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Mar 20, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.