starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 06:05:57 +03:00

[GH-ISSUE #1664] Discord Alert: Only use public IP #1296

New issue

Closed

opened 2026-02-27 02:56:21 +03:00 by kerem · 6 comments

kerem commented

2026-02-27 02:56:21 +03:00

Owner

Originally created by @robobenklein on GitHub (Oct 21, 2017).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1664

Originally assigned to: @dgibbs64 on GitHub.

github.com/GameServerManagers/LinuxGSM@8b163a61c4/lgsm/functions/alert_discord.sh (L42)

Test environment: TF2 on Ubuntu server.

When on a server with multiple interfaces, we need to set the ip variable so that the source engine knows where to bind the port, but that's a local network IP address. (192.168.X.X or whatever the network might be)

In the discord notification, it then uses the private IP address, meaning it's useless to have a gameserver tracker link there at all; nobody but the ones inside the network can even know what the address is.

Proposed workaround:

Allow custom variable to override ip variable.

Changes here:

"value": "[${ip}:${port}](https://www.gametracker.com/server_info/${ip}:${port})"

"value": "[${public_ip:-$ip}:${public_port:-$port}](https://www.gametracker.com/server_info/${public_ip:-$ip}:${public_port:-$port})"

Using public_ip and public_port if given allowing ip and port to be overridden if the router or network changes them in transit to the server.

I could submit a PR if needed, but this is such a small change I figured it wasn't that big a deal.

Originally created by @robobenklein on GitHub (Oct 21, 2017). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1664 Originally assigned to: @dgibbs64 on GitHub. https://github.com/GameServerManagers/LinuxGSM/blob/8b163a61c44f237ffb45fcb9cc4cd9cc237a73fd/lgsm/functions/alert_discord.sh#L42 Test environment: TF2 on Ubuntu server. When on a server with multiple interfaces, we need to set the `ip` variable so that the source engine knows where to bind the port, but that's a local network IP address. (192.168.X.X or whatever the network might be) In the discord notification, it then uses the private IP address, meaning it's useless to have a gameserver tracker link there at all; nobody but the ones inside the network can even know what the address is. ## Proposed workaround: Allow custom variable to override `ip` variable. Changes here: ``` "value": "[${ip}:${port}](https://www.gametracker.com/server_info/${ip}:${port})" ``` to ``` "value": "[${public_ip:-$ip}:${public_port:-$port}](https://www.gametracker.com/server_info/${public_ip:-$ip}:${public_port:-$port})" ``` Using `public_ip` and `public_port` if given allowing `ip` and `port` to be overridden if the router or network changes them in transit to the server. I could submit a PR if needed, but this is such a small change I figured it wasn't that big a deal.

kerem

2026-02-27 02:56:21 +03:00

closed this issue
added the
type: bug

outcome: issue resolved
labels

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Oct 25, 2017):

I like this idea. Thanks

@dgibbs64 commented on GitHub (Oct 25, 2017): I like this idea. Thanks

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@gamersalpha commented on GitHub (Nov 6, 2017):

same problem

thanks

@gamersalpha commented on GitHub (Nov 6, 2017): same problem thanks

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Apr 8, 2018):

LinuxGSM now has an internet ip variable. I think I will set it to this instead

@dgibbs64 commented on GitHub (Apr 8, 2018): LinuxGSM now has an internet ip variable. I think I will set it to this instead

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Apr 8, 2018):

I will be altering the IP to use extip however some though does need to go in to all the possible variations of how IP addresses may change

@dgibbs64 commented on GitHub (Apr 8, 2018): I will be altering the IP to use extip however some though does need to go in to all the possible variations of how IP addresses may change

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Nov 23, 2018):

Updated this for other notifications as well

@dgibbs64 commented on GitHub (Nov 23, 2018): Updated this for other notifications as well

kerem commented

2026-02-27 02:56:22 +03:00

Author

Owner

@lock[bot] commented on GitHub (Nov 24, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Nov 24, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

kerem referenced this issue

2026-02-27 03:54:19 +03:00

[PR #1662] [MERGED] 171014.1 #3388