starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 14:15:59 +03:00

[GH-ISSUE #1563] backup "fails" because --exclude isn't working as expected #1220

New issue

Closed

opened 2026-02-27 02:55:57 +03:00 by kerem · 7 comments

kerem commented

2026-02-27 02:55:57 +03:00

Owner

Originally created by @marvinlehmann on GitHub (Aug 3, 2017).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1563

Originally assigned to: @UltimateByte on GitHub.

Introduced with 0a8bfc3c25 (Line in question)

marvin@ubuntu:~$ ./boserver backup
[  OK  ] Backup boserver: Backup starting
[ INFO ] Backup boserver: There are no previous backups
[ .... ] Backup boserver: Backup (108M) boserver-2017-08-03-230045.tar.gz, in progress...tar: ./backups: file changed as we read it
FAIL
[ FAIL ] Backup boserver: Starting backup

It doesn't work because relative and absolute paths are mixed. The backup will still be created but will also contain the previous ones.

Variant 1:
tar -czf "${backupdir}/${backupname}.tar.gz" --exclude="${backupdir}" --absolute-names ${rootdir}/*

.. would work but then you have \\home\<user>\ in the archive.

I just can't find a good solution to it.

EDIT:
Variant 2:

excludedir=$(realpath --relative-to="${rootdir}" "${backupdir}")
tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${excludedir}" ./*

What about that?

Originally created by @marvinlehmann on GitHub (Aug 3, 2017). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1563 Originally assigned to: @UltimateByte on GitHub. Introduced with 0a8bfc3c258665d1963025c277c9c220def8fb95 ([Line in question](https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/command_backup.sh#L115)) ``` marvin@ubuntu:~$ ./boserver backup [ OK ] Backup boserver: Backup starting [ INFO ] Backup boserver: There are no previous backups [ .... ] Backup boserver: Backup (108M) boserver-2017-08-03-230045.tar.gz, in progress...tar: ./backups: file changed as we read it FAIL [ FAIL ] Backup boserver: Starting backup ``` It doesn't work because relative and absolute paths are mixed. The backup will still be created but will also contain the previous ones. **Variant 1:** `tar -czf "${backupdir}/${backupname}.tar.gz" --exclude="${backupdir}" --absolute-names ${rootdir}/*` .. would work but then you have `\\home\<user>\` in the archive. I just can't find a good solution to it. EDIT: **Variant 2:** ``` excludedir=$(realpath --relative-to="${rootdir}" "${backupdir}") tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${excludedir}" ./* ``` What about that?

kerem

2026-02-27 02:55:57 +03:00

closed this issue
added the
type: bug
label

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 3, 2017):

Isn't backupdir an absolute path ? If not, that's what we should probably correct.

@UltimateByte commented on GitHub (Aug 3, 2017): Isn't backupdir an absolute path ? If not, that's what we should probably correct.

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@marvinlehmann commented on GitHub (Aug 3, 2017):

It is but -C "${rootdir}" ./* is relative.

EDIT:
We should also keep in mind how to implement #1535. A few games have files in hidden directories like 7DTD, DST or Terraria. All have customizable paths though.

With the first variant we could just add these paths that can be defined somewhere (probably comma separated) to command for including them. With variant 2 we would have ugly paths in the archive.

@marvinlehmann commented on GitHub (Aug 3, 2017): It is but `-C "${rootdir}" ./*` is relative. EDIT: We should also keep in mind how to implement #1535. A few games have files in hidden directories like 7DTD, DST or Terraria. All have customizable paths though. With the first variant we could just add these paths that can be defined somewhere (probably comma separated) to command for including them. With variant 2 we would have ugly paths in the archive.

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@Grimston commented on GitHub (Aug 24, 2017):

The issue is lgsm/functions/command_backup.sh (Line 115)
tar can only use relative or absolute paths, not both backupdir being the full absolute path will not work when you are then using relative paths to create the archive reverting the change here: github.com/GameServerManagers/LinuxGSM@0a8bfc3c25

to:

tar --exclude "backups" -cjf "${backupdir}/${backupname}.tar.bzip2" -C "${rootdir}" ./*

exclude is required to be at the front for some versions of tar an oddity now, but to be safe it should be moved.

A new param could be added for the exclusion path but will need to be relative to the ${rootdir}

@Grimston commented on GitHub (Aug 24, 2017): The issue is `lgsm/functions/command_backup.sh` (Line 115) tar can only use relative or absolute paths, not both backupdir being the full absolute path will not work when you are then using relative paths to create the archive reverting the change here: https://github.com/GameServerManagers/LinuxGSM/commit/0a8bfc3c258665d1963025c277c9c220def8fb95 to: ```BASH tar --exclude "backups" -cjf "${backupdir}/${backupname}.tar.bzip2" -C "${rootdir}" ./* ``` exclude is required to be at the front for some versions of tar an oddity now, but to be safe it should be moved. A new param could be added for the exclusion path but will need to be relative to the ${rootdir}

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@ChrLau commented on GitHub (Oct 10, 2017):

EDIT: While that worked, it is way better to set the backupdir variable in your instance config, so you don't need to modify an LGSM script file. Which, additionally, can be overwritten at any time when updating LGSM.
In my instance config in lgsm/config-lgsm/rustserver/rustserver.cfg I simply specified:

# To fix: https://github.com/GameServerManagers/LinuxGSM/issues/1563
## Backup Directory
backupdir="backups"

Which overwrittes the default configuration in lgsm/config-lgsm/rustserver/_default.cfg:

## Backup Directory
backupdir="${rootdir}/backups"

And it works. No error message and backups only include the server files and not additionally all previously generated backups from the ./backups directory.

DON'T use this. Read above.
Sorry to hop in on this, I'm a first time user running into this problem with my Rust server. I changed the line 115 in lgsm/functions/command_backup.sh to the following:

#tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${backupdir}" ./*
tar --exclude "backups" -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" ./*

And this works. No tar error message during backup and the created backup files don't include previously generated backups anymore.

@ChrLau commented on GitHub (Oct 10, 2017): **EDIT:** While that worked, it is way better to set the backupdir variable in your instance config, so you don't need to modify an LGSM script file. Which, additionally, can be overwritten at any time when updating LGSM. In my instance config in `lgsm/config-lgsm/rustserver/rustserver.cfg` I simply specified: # To fix: https://github.com/GameServerManagers/LinuxGSM/issues/1563 ## Backup Directory backupdir="backups" Which overwrittes the default configuration in `lgsm/config-lgsm/rustserver/_default.cfg`: ## Backup Directory backupdir="${rootdir}/backups" And it works. No error message and backups only include the server files and not additionally all previously generated backups from the ./backups directory. **DON'T use this. Read above.** Sorry to hop in on this, I'm a first time user running into this problem with my Rust server. I changed the line 115 in `lgsm/functions/command_backup.sh` to the following: #tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${backupdir}" ./* tar --exclude "backups" -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" ./* And this works. No tar error message during backup and the created backup files don't include previously generated backups anymore.

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 29, 2017):

Tested working:

excludedir=$(realpath --relative-to="${rootdir}" "${backupdir}")
tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${excludedir}" ./*

Clever fix, I'm PRing

@UltimateByte commented on GitHub (Oct 29, 2017): Tested working: ``` excludedir=$(realpath --relative-to="${rootdir}" "${backupdir}") tar -czf "${backupdir}/${backupname}.tar.gz" -C "${rootdir}" --exclude "${excludedir}" ./* ``` Clever fix, I'm PRing

kerem commented

2026-02-27 02:55:57 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 30, 2017):

Fixed.

@UltimateByte commented on GitHub (Oct 30, 2017): Fixed.

kerem commented

2026-02-27 02:55:58 +03:00

Author

Owner

@lock[bot] commented on GitHub (Oct 30, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Oct 30, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

kerem referenced this issue

2026-02-27 03:53:58 +03:00

[PR #1220] [MERGED] Tabulation fix #3289