[PR #6] [MERGED] Fix 5 bugs found in sixth review pass #8

New issue

Closed

opened 2026-03-13 13:04:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 13:04:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/291-Group/LAN-Orangutan/pull/6
Author: @FileBay
Created: 12/31/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @FileBay

Base: main ← Head: claude/audit-code-bugs-NaPWC

📝 Commits (1)

927cbab Fix 5 bugs found in sixth review pass

📊 Changes

4 files changed (+31 additions, -8 deletions)

View changed files

📝 cli/orangutan (+9 -1)
📝 uninstall.sh (+12 -1)
📝 web/assets/app.js (+8 -4)
📝 web/settings.php (+2 -2)

📄 Description

Medium:

Fix updateDeviceGroup showing no feedback on failure - user now sees error toast when group update fails
Fix CLI list command crash on malformed IP in devices.json - now gracefully handles malformed IPs by sorting them last

Low:

Fix uninstall.sh not cleaning up custom port firewall rules - now reads configured port from config before deletion and cleans it up
Show actual server error messages in saveDevice and deleteDevice instead of generic "Failed to update/delete" messages
Escape PHP version and use intval for disk_free_mb in settings.php for consistency with other output escaping

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/291-Group/LAN-Orangutan/pull/6 **Author:** [@FileBay](https://github.com/FileBay) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@FileBay](https://github.com/FileBay) **Base:** `main` ← **Head:** `claude/audit-code-bugs-NaPWC` --- ### 📝 Commits (1) - [`927cbab`](https://github.com/291-Group/LAN-Orangutan/commit/927cbab159168f5579a9e1c0ba0e80b51cbed4ec) Fix 5 bugs found in sixth review pass ### 📊 Changes **4 files changed** (+31 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `cli/orangutan` (+9 -1) 📝 `uninstall.sh` (+12 -1) 📝 `web/assets/app.js` (+8 -4) 📝 `web/settings.php` (+2 -2) </details> ### 📄 Description Medium: - Fix updateDeviceGroup showing no feedback on failure - user now sees error toast when group update fails - Fix CLI list command crash on malformed IP in devices.json - now gracefully handles malformed IPs by sorting them last Low: - Fix uninstall.sh not cleaning up custom port firewall rules - now reads configured port from config before deletion and cleans it up - Show actual server error messages in saveDevice and deleteDevice instead of generic "Failed to update/delete" messages - Escape PHP version and use intval for disk_free_mb in settings.php for consistency with other output escaping --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>