[PR #10] [MERGED] feat(ui): expose fake_reasoning toggle in settingsCodex/add fake reasoning toggle #14

Closed
opened 2026-03-16 12:14:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hnewcity/KiroaaS/pull/10
Author: @RegenLau
Created: 3/8/2026
Status: Merged
Merged: 3/10/2026
Merged by: @hnewcity

Base: mainHead: codex/add-fake-reasoning-toggle


📝 Commits (2)

  • 7e5abc1 feat: add fake reasoning toggle to settings
  • 25ff088 feat: surface thinking toggle in settings

📊 Changes

6 files changed (+59 additions, -30 deletions)

View changed files

📝 README.md (+1 -0)
📝 docs/README_zh.md (+1 -0)
📝 src-tauri/src/main.rs (+1 -1)
📝 src/App.tsx (+0 -26)
📝 src/components/SettingsForm.tsx (+32 -3)
📝 src/lib/i18n.ts (+24 -0)

📄 Description

Summary

  • expose the existing fake_reasoning config as a toggle in Settings
  • place the toggle in the main settings form above Security Settings
  • update the English and Chinese documentation

Motivation

fake_reasoning was already supported internally, but it was not available in the desktop UI. Users had to edit config.json manually to control whether thinking output was shown.

This change only surfaces the existing option in Settings and does not change the default behavior.

This PR is intentionally limited to exposing the existing config option in the UI.

Testing

  • ran npm run build
  • verified the toggle appears in Settings
  • verified the toggle updates config.fake_reasoning
  • verified the behavior works in the local desktop app

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hnewcity/KiroaaS/pull/10 **Author:** [@RegenLau](https://github.com/RegenLau) **Created:** 3/8/2026 **Status:** ✅ Merged **Merged:** 3/10/2026 **Merged by:** [@hnewcity](https://github.com/hnewcity) **Base:** `main` ← **Head:** `codex/add-fake-reasoning-toggle` --- ### 📝 Commits (2) - [`7e5abc1`](https://github.com/hnewcity/KiroaaS/commit/7e5abc1ed6ba626abb8311cba84affd2d143d88d) feat: add fake reasoning toggle to settings - [`25ff088`](https://github.com/hnewcity/KiroaaS/commit/25ff088b52995368fac64d7cea2bef3a6b70ed18) feat: surface thinking toggle in settings ### 📊 Changes **6 files changed** (+59 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `docs/README_zh.md` (+1 -0) 📝 `src-tauri/src/main.rs` (+1 -1) 📝 `src/App.tsx` (+0 -26) 📝 `src/components/SettingsForm.tsx` (+32 -3) 📝 `src/lib/i18n.ts` (+24 -0) </details> ### 📄 Description ## Summary - expose the existing `fake_reasoning` config as a toggle in Settings - place the toggle in the main settings form above Security Settings - update the English and Chinese documentation ## Motivation `fake_reasoning` was already supported internally, but it was not available in the desktop UI. Users had to edit `config.json` manually to control whether thinking output was shown. This change only surfaces the existing option in Settings and does not change the default behavior. This PR is intentionally limited to exposing the existing config option in the UI. ## Testing - ran `npm run build` - verified the toggle appears in Settings - verified the toggle updates `config.fake_reasoning` - verified the behavior works in the local desktop app --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-16 12:14:41 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/KiroaaS#14
No description provided.