mirror of
https://github.com/davidarroyo1234/InstagramUnfollowers.git
synced 2026-04-25 21:05:49 +03:00
[GH-ISSUE #84] Crashes chromium browsers #230
Labels
No labels
bug
documentation
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/InstagramUnfollowers#230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sooswastaken on GitHub (May 7, 2023).
Original GitHub issue: https://github.com/davidarroyo1234/InstagramUnfollowers/issues/84
The main gh page crashes chrome and arc, but not safari for me.
@sooswastaken commented on GitHub (May 7, 2023):
The script being in one line is insane
@tomleb3 commented on GitHub (May 7, 2023):
@sooswastaken Yes, ever since the inclusion of Preact and some new major features on top of that, it's an issue we've been dancing around.
While including Preact greatly improved the DX, the drawback is the output size.
@davidarroyo1234 What do you think about this?
Maybe it's time we re-visit the idea of turning it into an extension or a bookmarklet?
Or perhaps come up with some alternative way of presenting the script.
@sooswastaken commented on GitHub (May 7, 2023):
Making it a bookmarklet could probably work, they are just links right? I didn't realize that you guys were using an entire library lmfao.
If you guys decide to go the extension route, #21: I would love to see a feature where the current followers are saved to storage, and revisiting the extension could show changes in that data. The notification system might be too much tho.
@tomleb3 commented on GitHub (May 7, 2023):
Say what you will, but makes it a hell of a lot easier and more satisfying to work on than vanilla JS lol
Definitely feasible, even the notification system can potentially work with some cron job that runs at a specific time of day, but that complicates things and would require the user to fork the project and do some set-ups, etc...
However, we already do use storage for the whitelisting feature, so don't see the problem with enhancing it further to include some badge or even a dedicated "new" screen or tab.
I like that idea, but we probably should hold out on adding more stuff until we decide the right course of action in regards to the issue here.
@davidarroyo1234 commented on GitHub (May 8, 2023):
I mean its a big chunk of code but at the same time is not too big compared with other scripts that i have use previously. Could you provide you computer specs and chome version?
I dont like to much the extension idea because its "propietary". I could make the extension for offline installing and with this option would remain "open" source.
@tomleb3 commented on GitHub (Jul 31, 2023):
Not part of the readme anymore.
So this one is solved.