[PR #257] [CLOSED] Supporting carousel posts that start with a video #905

New issue

Closed

opened 2026-03-13 22:52:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 22:52:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/alexal1/Insomniac/pull/257
Author: @simonmannsfeld
Created: 1/20/2021
Status: ❌ Closed

Base: master ← Head: patch-2

📝 Commits (1)

932ec3c Supporting carousel posts that start with a video

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 insomniac/actions_impl.py (+1 -1)

📄 Description

Looks like Insomniac is crashing on every carousel which is starting with a video.

Images are placed to a id/zoomable_view_container, carousels which start with an image are placed to a id/carousel_image.
But carousels that start with a video are placed to a id/carousel_video_container.

Looks like Issue #239 is reporting that.

This fix is untested, please triplecheck. Testing is not thrilling me. lol

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/alexal1/Insomniac/pull/257 **Author:** [@simonmannsfeld](https://github.com/simonmannsfeld) **Created:** 1/20/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`932ec3c`](https://github.com/alexal1/Insomniac/commit/932ec3c9ff949af0849e3ee399dee04d417fe26f) Supporting carousel posts that start with a video ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `insomniac/actions_impl.py` (+1 -1) </details> ### 📄 Description Looks like Insomniac is crashing on every carousel which is starting with a video. Images are placed to a `id/zoomable_view_container`, carousels which start with an image are placed to a `id/carousel_image`. But carousels that start with a video are placed to a `id/carousel_video_container`. Looks like Issue #239 is reporting that. This fix is untested, please triplecheck. Testing is not thrilling me. lol --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>