mirror of
https://github.com/alexal1/Insomniac.git
synced 2026-04-26 10:05:50 +03:00
[GH-ISSUE #239] If video is opened as part of interact action, Insomniac crashes #656
Labels
No labels
bug
duplicate
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Insomniac#656
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jan 6, 2021).
Original GitHub issue: https://github.com/alexal1/Insomniac/issues/239
@Fadude commented on GitHub (Jan 6, 2021):
@Ardy000 Can you send a zip-crash please?
@ghost commented on GitHub (Jan 6, 2021):
Yeah I will next time it happens.
I was wrong to say it happened on video. I just watched it do video without issue. I'm not sure if it's only video. I've never seen it crash on pictures but it could have
@simonmannsfeld commented on GitHub (Jan 20, 2021):
Crash-2021-01-20-17-42-18.zip
I guess I had the same crash. It looks like insomniac is crashing on opening a carousel that starts with a video.
I created pull request #257 for this. It's still untested because I love the thill! Please triplecheck - I don't know what I am doing. lol 😆 Please merge and close if it works.
EDIT: Pull request #257 closed. It does work but causing other bugs, larger bugs.
@simonmannsfeld commented on GitHub (Jan 21, 2021):
Carousels that start with a video uses the resource-id
com.instagram.android:id/carousel_video_image. Just waiting for someone who can fix. 😄@alexal1 commented on GitHub (Mar 20, 2021):
Fixed in
v3.7.0