[PR #187] [CLOSED] Updated path to be platform-independent #436

Closed
opened 2026-03-02 23:40:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/alexal1/Insomniac/pull/187
Author: @giacomo-b
Created: 11/17/2020
Status: Closed

Base: masterHead: platform-independent-path


📝 Commits (3)

  • 4dc0f67 Updated path to be platform-independent
  • 4b797f6 Fixed additional file-dependent paths
  • 21371cd Finished fixing system-dependent paths

📊 Changes

3 files changed (+11 additions, -11 deletions)

View changed files

📝 insomniac/persistent_list.py (+1 -1)
📝 insomniac/storage.py (+7 -7)
📝 insomniac/utils.py (+3 -3)

📄 Description

Updated path so that it is platform independent:

Before:
path = directory + self.filename + ".json"

After:
path = os.path.join(directory, self.filename + ".json")


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/alexal1/Insomniac/pull/187 **Author:** [@giacomo-b](https://github.com/giacomo-b) **Created:** 11/17/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `platform-independent-path` --- ### 📝 Commits (3) - [`4dc0f67`](https://github.com/alexal1/Insomniac/commit/4dc0f67542494bdb661268990e079db7361b7afd) Updated path to be platform-independent - [`4b797f6`](https://github.com/alexal1/Insomniac/commit/4b797f615cc842f074140e93cbfdf9dc27690bc0) Fixed additional file-dependent paths - [`21371cd`](https://github.com/alexal1/Insomniac/commit/21371cd504173c3e75ba66cd9b2d52870759fa00) Finished fixing system-dependent paths ### 📊 Changes **3 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `insomniac/persistent_list.py` (+1 -1) 📝 `insomniac/storage.py` (+7 -7) 📝 `insomniac/utils.py` (+3 -3) </details> ### 📄 Description Updated `path` so that it is platform independent: **Before**: `path = directory + self.filename + ".json"` **After**: `path = os.path.join(directory, self.filename + ".json")` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:40:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Insomniac#436
No description provided.