[GH-ISSUE #7] LpacErrDialog will be popup three times if there's no card while click the refresh button #61

Closed
opened 2026-03-07 19:57:53 +03:00 by kerem · 0 comments
Owner

Originally created by @quul on GitHub (Mar 6, 2024).
Original GitHub issue: https://github.com/creamlike1024/EasyLPAC/issues/7

Description

LpacErrDialog will be popup three times if there's no card while click the refresh button.

Screenshots

https://github.com/creamlike1024/EasyLPAC/assets/56734434/98cb1518-8798-46df-9e03-c1453ee0b089

Environment

EasyLPAC: 0.6.7
macOS: 14.2

Dive into

It seems happes because of each function below call the ShowLpacErrDialog function
github.com/creamlike1024/EasyLPAC@f567f7ba42/control.go (L153-L155)
But due to the lack knowledge of golang, I don't know which is the best practice, so I'm afraid I can't PR. :(
Anyway, just a little bug(

Originally created by @quul on GitHub (Mar 6, 2024). Original GitHub issue: https://github.com/creamlike1024/EasyLPAC/issues/7 # Description `LpacErrDialog` will be popup three times if there's no card while click the refresh button. # Screenshots https://github.com/creamlike1024/EasyLPAC/assets/56734434/98cb1518-8798-46df-9e03-c1453ee0b089 # Environment EasyLPAC: 0.6.7 macOS: 14.2 # Dive into It seems happes because of each function below call the `ShowLpacErrDialog` function https://github.com/creamlike1024/EasyLPAC/blob/f567f7ba42d7bbca149182796f1e8f047faf30f2/control.go#L153-L155 But due to the lack knowledge of golang, I don't know which is the best practice, so I'm afraid I can't PR. :( Anyway, just a little bug(
kerem closed this issue 2026-03-07 19:57:53 +03:00
Sign in to join this conversation.
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/EasyLPAC#61
No description provided.