starred/EasyLPAC
1
0
Fork 0
mirror of https://github.com/creamlike1024/EasyLPAC.git synced 2026-04-25 21:05:50 +03:00
Code Issues 23 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #7] LpacErrDialog will be popup three times if there's no card while click the refresh button #1

New issue
Closed
opened 2026-03-04 23:13:17 +03:00 by kerem · 2 comments
kerem commented 2026-03-04 23:13:17 +03:00
Owner
Copy link

Originally created by @quul on GitHub (Mar 6, 2024).
Original GitHub issue: https://github.com/creamlike1024/EasyLPAC/issues/7

Description

LpacErrDialog will be popup three times if there's no card while click the refresh button.

Screenshots

https://github.com/creamlike1024/EasyLPAC/assets/56734434/98cb1518-8798-46df-9e03-c1453ee0b089

Environment

EasyLPAC: 0.6.7
macOS: 14.2

Dive into

It seems happes because of each function below call the ShowLpacErrDialog function
github.com/creamlike1024/EasyLPAC@f567f7ba42/control.go (L153-L155)
But due to the lack knowledge of golang, I don't know which is the best practice, so I'm afraid I can't PR. :(
Anyway, just a little bug(

Originally created by @quul on GitHub (Mar 6, 2024). Original GitHub issue: https://github.com/creamlike1024/EasyLPAC/issues/7 # Description `LpacErrDialog` will be popup three times if there's no card while click the refresh button. # Screenshots https://github.com/creamlike1024/EasyLPAC/assets/56734434/98cb1518-8798-46df-9e03-c1453ee0b089 # Environment EasyLPAC: 0.6.7 macOS: 14.2 # Dive into It seems happes because of each function below call the `ShowLpacErrDialog` function https://github.com/creamlike1024/EasyLPAC/blob/f567f7ba42d7bbca149182796f1e8f047faf30f2/control.go#L153-L155 But due to the lack knowledge of golang, I don't know which is the best practice, so I'm afraid I can't PR. :( Anyway, just a little bug(
kerem closed this issue 2026-03-04 23:13:18 +03:00
kerem commented 2026-03-04 23:13:23 +03:00
Author
Owner
Copy link

@creamlike1024 commented on GitHub (Mar 7, 2024):

Perhaps we need to stop subsequent refresh operations when errors occur

<!-- gh-comment-id:1983714131 --> @creamlike1024 commented on GitHub (Mar 7, 2024): Perhaps we need to stop subsequent refresh operations when errors occur
kerem commented 2026-03-04 23:13:23 +03:00
Author
Owner
Copy link

@creamlike1024 commented on GitHub (Mar 15, 2024):

Attempted to solve this bug
github.com/creamlike1024/EasyLPAC@bd83666c23/control.go (L151-L172)

<!-- gh-comment-id:1999005769 --> @creamlike1024 commented on GitHub (Mar 15, 2024): Attempted to solve this bug https://github.com/creamlike1024/EasyLPAC/blob/bd83666c23fb9ce1c575d5da2172cf3d45132e6a/control.go#L151-L172
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
0.8.0.2
0.7.9.3
0.7.9.2
0.7.8.4
0.7.8.3
0.7.8.2
0.7.7.2
0.7.7.1
0.7.6.6
0.7.6.5
0.7.6.3
0.7.6.2
0.7.6
0.7.5-build2
0.7.5
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.8
0.6.7
0.6.6
0.6.5
0.6.4-ci20240204
0.6.3
0.6.2
0.6.1
0.6.0
0.5.4
0.5.3
0.5.2
0.5.1
0.4.1
0.4.0
0.3.0
v0.2.0-test
v0.1.0
v0.0.2
v0.0.1
Labels
Clear labels   
bug

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/EasyLPAC#1
No description provided.