mirror of
https://github.com/sickcodes/Docker-OSX.git
synced 2026-04-27 00:25:48 +03:00
[GH-ISSUE #470] TEMP-FIX is breaking Dockerfile.nakedvnc build #342
Labels
No labels
bug
documentation
enhancement
following upstream developments
good first issue
help wanted
invalid
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Docker-OSX#342
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Andrflor on GitHub (Mar 21, 2022).
Original GitHub issue: https://github.com/sickcodes/Docker-OSX/issues/470
The glibc has now been updated to 2.34
The TEMP-FIX in the vnc dockerfile is now not fixing the install anymore but breaking it.
The code in TEMP-FIX is not needed anymore. It even must be removed to process proper build.
Thx for this masterpiece btw 🙂
@sickcodes commented on GitHub (Mar 27, 2022):
Thanks for letting me know!
@sickcodes commented on GitHub (Mar 27, 2022):
What about libguestfs, do you want that patch?
@Andrflor commented on GitHub (Mar 29, 2022):
The libguestfs patch is not needed anymore.
I got an all functioning build without any patch.
Thanks for the PR, the diff will close this issue.
@sickcodes commented on GitHub (Mar 31, 2022):
So this works: https://github.com/sickcodes/Docker-OSX/pull/472?
If so, I'll merge
@Andrflor commented on GitHub (Apr 7, 2022):
Yes it does