[PR #148] [MERGED] fix: add zlib to SPC_WINDOWS_LIBS; drop win32-arm64 target #279

New issue

Closed

opened 2026-03-07 20:42:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 20:42:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DBDiff/DBDiff/pull/148
Author: @jasdeepkhalsa
Created: 3/7/2026
Status: ✅ Merged
Merged: 3/7/2026
Merged by: @jasdeepkhalsa

Base: master ← Head: feature/fix-win-release-3

📝 Commits (1)

412e719 fix: add zlib to SPC_WINDOWS_LIBS; drop win32-arm64 target

📊 Changes

1 file changed (+10 additions, -8 deletions)

View changed files

📝 .github/workflows/release.yml (+10 -8)

📄 Description

win32-x64: linker fails with 14 unresolved zlib symbols (compress, uncompress, deflate, inflate, gzdopen, etc.) because zlib is in SPC_EXTENSIONS but not SPC_WINDOWS_LIBS. On Windows there is no system zlib, so it must be listed explicitly for SPC to download and link zlib_a.lib. Fix: prepend zlib to SPC_WINDOWS_LIBS.

win32-arm64: SPC v2.8.2 hard-codes phpsdk-vs17-x64.bat, which passes 'x64_amd64' to vcvarsall.bat — an invalid argument on an ARM64 host (valid are amd64_arm64 etc.). It also always downloads the postgresql-16-windows-x64-binaries.zip regardless of runner arch. These are upstream SPC bugs; drop the target from the matrix and the publish step until SPC gains proper Windows ARM64 support. The npm package @dbdiff/cli-win32-arm64 skeleton is kept in place so arm64 Windows users get a clean 'Could not locate binary' error rather than an npm install failure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DBDiff/DBDiff/pull/148 **Author:** [@jasdeepkhalsa](https://github.com/jasdeepkhalsa) **Created:** 3/7/2026 **Status:** ✅ Merged **Merged:** 3/7/2026 **Merged by:** [@jasdeepkhalsa](https://github.com/jasdeepkhalsa) **Base:** `master` ← **Head:** `feature/fix-win-release-3` --- ### 📝 Commits (1) - [`412e719`](https://github.com/DBDiff/DBDiff/commit/412e719d4f354da919d6d3c38abceb0ab4da6e3d) fix: add zlib to SPC_WINDOWS_LIBS; drop win32-arm64 target ### 📊 Changes **1 file changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+10 -8) </details> ### 📄 Description win32-x64: linker fails with 14 unresolved zlib symbols (compress, uncompress, deflate, inflate, gzdopen, etc.) because zlib is in SPC_EXTENSIONS but not SPC_WINDOWS_LIBS. On Windows there is no system zlib, so it must be listed explicitly for SPC to download and link zlib_a.lib. Fix: prepend zlib to SPC_WINDOWS_LIBS. win32-arm64: SPC v2.8.2 hard-codes phpsdk-vs17-x64.bat, which passes 'x64_amd64' to vcvarsall.bat — an invalid argument on an ARM64 host (valid are amd64_arm64 etc.). It also always downloads the postgresql-16-windows-x64-binaries.zip regardless of runner arch. These are upstream SPC bugs; drop the target from the matrix and the publish step until SPC gains proper Windows ARM64 support. The npm package @dbdiff/cli-win32-arm64 skeleton is kept in place so arm64 Windows users get a clean 'Could not locate binary' error rather than an npm install failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>