[PR #123] Some fixes #264

New issue

Open

opened 2026-03-07 20:42:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 20:42:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DBDiff/DBDiff/pull/123
Author: @zorn-v
Created: 7/10/2021
Status: 🔄 Open

Base: master ← Head: some-fixes

📝 Commits (10+)

92a2d29 Allow pass params to DBData
b25a48d Pass params to DBData
2a685b7 Pass params to DBSchema
5ed0273 Fix pass params to DBSchema
d40f33b Skip diff for views
30410e8 Fix AddTableSQL for views
c0724fb Default mysql port
2d8a4aa Fix drop key order
87a418a Use passed params in varios places
38af2d8 Fix drop primary key

📊 Changes

11 files changed (+93 additions, -47 deletions)

View changed files

📝 src/DB/DBManager.php (+9 -3)
📝 src/DB/Data/ArrayDiff.php (+12 -6)
📝 src/DB/Data/DBData.php (+9 -4)
📝 src/DB/Data/DistTableData.php (+3 -2)
📝 src/DB/Data/LocalTableData.php (+14 -9)
📝 src/DB/Data/TableData.php (+4 -4)
📝 src/DB/DiffCalculator.php (+5 -5)
📝 src/DB/Schema/DBSchema.php (+9 -4)
📝 src/DB/Schema/TableSchema.php (+13 -5)
📝 src/SQLGen/DiffToSQL/AddTableSQL.php (+2 -2)
📝 src/SQLGen/DiffToSQL/AlterTableChangeKeySQL.php (+13 -3)

📄 Description

Allow to pass "crafted" parameters (do not use cli getter), fix get diff tables on dist servers, fix change primary index, do not try to change views and so on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DBDiff/DBDiff/pull/123 **Author:** [@zorn-v](https://github.com/zorn-v) **Created:** 7/10/2021 **Status:** 🔄 Open **Base:** `master` ← **Head:** `some-fixes` --- ### 📝 Commits (10+) - [`92a2d29`](https://github.com/DBDiff/DBDiff/commit/92a2d29d3e936eaae5ed1e01b3e67fb48ec030fc) Allow pass params to DBData - [`b25a48d`](https://github.com/DBDiff/DBDiff/commit/b25a48d3c904d0557871e42edf2e35fb1cedadda) Pass params to DBData - [`2a685b7`](https://github.com/DBDiff/DBDiff/commit/2a685b71fbbb5d1cdc6eeb952cdde8ffa4e253af) Pass params to DBSchema - [`5ed0273`](https://github.com/DBDiff/DBDiff/commit/5ed02738be8b7cb22bfb3ca742a9192c49d72ee8) Fix pass params to DBSchema - [`d40f33b`](https://github.com/DBDiff/DBDiff/commit/d40f33b97833e9030065b7a5eb50854a524e3b2e) Skip diff for views - [`30410e8`](https://github.com/DBDiff/DBDiff/commit/30410e80ed89eda0b37c542ada318814481313b1) Fix AddTableSQL for views - [`c0724fb`](https://github.com/DBDiff/DBDiff/commit/c0724fb08c3e939f0245dd2bfb87ab3bf680d740) Default mysql port - [`2d8a4aa`](https://github.com/DBDiff/DBDiff/commit/2d8a4aac6f8f565b4085f0d09567cde8651223d3) Fix drop key order - [`87a418a`](https://github.com/DBDiff/DBDiff/commit/87a418ab119cc436aa46f53ae44f6da68144b10a) Use passed params in varios places - [`38af2d8`](https://github.com/DBDiff/DBDiff/commit/38af2d8b87544e948bd98a35949bce32c34aba10) Fix drop primary key ### 📊 Changes **11 files changed** (+93 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/DB/DBManager.php` (+9 -3) 📝 `src/DB/Data/ArrayDiff.php` (+12 -6) 📝 `src/DB/Data/DBData.php` (+9 -4) 📝 `src/DB/Data/DistTableData.php` (+3 -2) 📝 `src/DB/Data/LocalTableData.php` (+14 -9) 📝 `src/DB/Data/TableData.php` (+4 -4) 📝 `src/DB/DiffCalculator.php` (+5 -5) 📝 `src/DB/Schema/DBSchema.php` (+9 -4) 📝 `src/DB/Schema/TableSchema.php` (+13 -5) 📝 `src/SQLGen/DiffToSQL/AddTableSQL.php` (+2 -2) 📝 `src/SQLGen/DiffToSQL/AlterTableChangeKeySQL.php` (+13 -3) </details> ### 📄 Description Allow to pass "crafted" parameters (do not use cli getter), fix get diff tables on dist servers, fix change primary index, do not try to change views and so on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>