[PR #93] Fixed calling undefined methods when columns added or removed #257

Open
opened 2026-03-07 20:42:32 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/DBDiff/DBDiff/pull/93
Author: @joshuactm
Created: 7/4/2019
Status: 🔄 Open

Base: masterHead: undefined_method_check


📝 Commits (2)

  • 6c38ec5 Fixed calling undefined methods
  • 8c37312 Merge branch 'master' into undefined_method_check

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/SQLGen/DiffToSQL/UpdateDataSQL.php (+7 -2)

📄 Description

When GetOldValue or GetNewValue are not defined, do not try and call methods, just treat as NULL.

This can happen when columns only exist in one of the tables being compared.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/DBDiff/DBDiff/pull/93 **Author:** [@joshuactm](https://github.com/joshuactm) **Created:** 7/4/2019 **Status:** 🔄 Open **Base:** `master` ← **Head:** `undefined_method_check` --- ### 📝 Commits (2) - [`6c38ec5`](https://github.com/DBDiff/DBDiff/commit/6c38ec59e005021ef13561a5b4d69300b347d80a) Fixed calling undefined methods - [`8c37312`](https://github.com/DBDiff/DBDiff/commit/8c37312f3c16ef8f6ee8f06c2e5ffc1c971bdf24) Merge branch 'master' into undefined_method_check ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SQLGen/DiffToSQL/UpdateDataSQL.php` (+7 -2) </details> ### 📄 Description When GetOldValue or GetNewValue are not defined, do not try and call methods, just treat as NULL. This can happen when columns only exist in one of the tables being compared. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/DBDiff#257
No description provided.