[GH-ISSUE #69] memory_limit #185

New issue

Open

opened 2026-03-07 20:41:56 +03:00 by kerem · 4 comments

kerem commented

2026-03-07 20:41:56 +03:00

Owner

Originally created by @Qrzysio on GitHub (Jan 11, 2018).
Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/69

In DBDiff.php file there is a line which sets up memory_limit to 512M.

ini_set('memory_limit', '512M');

This is wrong due to on local machines sometimes we have to set it up even higher. This value should only be set up by user and not appear in the class.

Originally created by @Qrzysio on GitHub (Jan 11, 2018). Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/69 In `DBDiff.php` file there is a line which sets up `memory_limit` to `512M`. `ini_set('memory_limit', '512M');` This is wrong due to on local machines sometimes we have to set it up even higher. This value should only be set up by user and not appear in the class.

kerem commented

2026-03-07 20:41:57 +03:00

Author

Owner

@makopov commented on GitHub (Jan 15, 2018):

I'm guessing this is so that we don't have to set our systems higher for just this script. However I ran into the same issue where it was not enough and I had to set it to 1024. They should just set this to 1024 in their script. Its not something ran often so its probably okay.

@makopov commented on GitHub (Jan 15, 2018): I'm guessing this is so that we don't have to set our systems higher for just this script. However I ran into the same issue where it was not enough and I had to set it to 1024. They should just set this to 1024 in their script. Its not something ran often so its probably okay.

kerem commented

2026-03-07 20:41:57 +03:00

Author

Owner

@aurora commented on GitHub (Jul 19, 2019):

Why even set it to a hard-coded value? Should at least be changeable using an option-switch.

@aurora commented on GitHub (Jul 19, 2019): Why even set it to a hard-coded value? Should at least be changeable using an option-switch.

kerem commented

2026-03-07 20:41:57 +03:00

Author

Owner

@dataf3l commented on GitHub (Oct 22, 2020):

I agree, this also bit me, I had to go fishing for the memory setting.

I guess nobody cares about this project...

@dataf3l commented on GitHub (Oct 22, 2020): I agree, this also bit me, I had to go fishing for the memory setting. I guess nobody cares about this project...

kerem commented

2026-03-07 20:41:57 +03:00

Author

Owner

@dataf3l commented on GitHub (Oct 22, 2020):

Maybe the program shouldn't put all the records in memory, no?

@dataf3l commented on GitHub (Oct 22, 2020): Maybe the program shouldn't put all the records in memory, no?