[GH-ISSUE #11] NULL values are not handled correctly in INSERT and UPDATE statemens #145

New issue

Closed

opened 2026-03-07 20:41:30 +03:00 by kerem · 2 comments

kerem commented

2026-03-07 20:41:30 +03:00

Owner

Originally created by @cinzko on GitHub (Jun 4, 2016).
Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/11

When a column contains NULL values the INSERT statement always genereates quotes with an empty string.
This can be fixed in "\DBDiff\SQLGen\DiffToSQL\InsertDataSQL"
by replacing

        $values = array_map(function ($el) {
            return "'".addslashes($el)."'";
        }, $values);

with

        $values = array_map(function ($el) {
            if(!is_null($el)) {
                return "'" . addslashes($el) . "'";
            }
            else {
                return 'NULL';
            }
        }, $values);

and also in "\DBDiff\SQLGen\DiffToSQL\UpdateDataSQL" by replacing

        array_walk($values, function(&$diff, $column) {
            $diff = '`'.$column."` = '".addslashes($diff->getNewValue())."'";
        });

with

        array_walk($values, function(&$diff, $column) {
            if(!is_null($diff->getNewValue())) {
                $diff = '`' . $column . "` = '" . addslashes($diff->getNewValue()) . "'";
            }
            else {
                $diff = '`' . $column . "` = NULL";
            }
        });

Best regards,
Christian

Originally created by @cinzko on GitHub (Jun 4, 2016). Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/11 When a column contains NULL values the INSERT statement always genereates quotes with an empty string. This can be fixed in "\DBDiff\SQLGen\DiffToSQL\InsertDataSQL" by replacing ``` $values = array_map(function ($el) { return "'".addslashes($el)."'"; }, $values); ``` with ``` $values = array_map(function ($el) { if(!is_null($el)) { return "'" . addslashes($el) . "'"; } else { return 'NULL'; } }, $values); ``` and also in "\DBDiff\SQLGen\DiffToSQL\UpdateDataSQL" by replacing ``` array_walk($values, function(&$diff, $column) { $diff = '`'.$column."` = '".addslashes($diff->getNewValue())."'"; }); ``` with ``` array_walk($values, function(&$diff, $column) { if(!is_null($diff->getNewValue())) { $diff = '`' . $column . "` = '" . addslashes($diff->getNewValue()) . "'"; } else { $diff = '`' . $column . "` = NULL"; } }); Best regards, Christian ```