[GH-ISSUE #7] Approaches for same server or not #140

New issue

Closed

opened 2026-03-07 20:41:28 +03:00 by kerem · 1 comment

kerem commented

2026-03-07 20:41:28 +03:00

Owner

Originally created by @webian on GitHub (May 15, 2016).
Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/7

Hi @jasdeepkhalsa,
I can't get the reason why you use 2 different approaches if the comparison is between same servers or different.
I mean this code in method getDiff of TableData:

if ($server1 == $server2) {
  return $this->localTableData->getDiff($table, $sourceKey);
} else {
  return $this->distTableData->getDiff($table, $sourceKey);
}

Please, can you help me to understand?

Originally created by @webian on GitHub (May 15, 2016). Original GitHub issue: https://github.com/DBDiff/DBDiff/issues/7 Hi @jasdeepkhalsa, I can't get the reason why you use 2 different approaches if the comparison is between same servers or different. I mean this code in method getDiff of TableData: ``` if ($server1 == $server2) { return $this->localTableData->getDiff($table, $sourceKey); } else { return $this->distTableData->getDiff($table, $sourceKey); } ``` Please, can you help me to understand?

kerem closed this issue

2026-03-07 20:41:29 +03:00

kerem commented

2026-03-07 20:41:30 +03:00

Author

Owner

@jasdeepkhalsa commented on GitHub (May 17, 2016):

If I have to guess the reason it's probably that when it's the same server and thus a local database, there are other clever optimizations that we do in order to make the diff super fast across millions of rows. I would doubt these optimizations would work if the database is a remote one.

@jasdeepkhalsa commented on GitHub (May 17, 2016): If I have to guess the reason it's probably that when it's the same server and thus a local database, there are other clever optimizations that we do in order to make the diff super fast across millions of rows. I would doubt these optimizations would work if the database is a remote one.

kerem referenced this issue

2026-03-07 20:42:37 +03:00

[PR #140] [CLOSED] Feature/sqlite postgres support #272