mirror of
https://github.com/nishchayp/DAMN.git
synced 2026-04-25 07:05:58 +03:00
[GH-ISSUE #9] Improvement: Presently storing IP as string. Find and implement a better way. #4
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/DAMN#4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nishchayp on GitHub (Dec 3, 2017).
Original GitHub issue: https://github.com/nishchayp/DAMN/issues/9
@ekamwalia commented on GitHub (Dec 9, 2017):
Isn't storing the IP as a string the most convenient way to store it given we can the easily pass it to the copy and remove scripts?
That is anyway all we need to do with the IP address
@nishchayp commented on GitHub (Dec 9, 2017):
The only problem I see here is error made by admin while entering the IP address but yes that could be handled by js form validation. Actually there were a few threads on SO about storing IP in a DB that is why I felt the need for this improvement. Let's just check it once if there are any major drawback of storing as string. If there are none then we can close this issue.
@ekamwalia commented on GitHub (Dec 9, 2017):
I agree to the mistake while storing part. But the validation is easy.
There are some IP types in the go net package. We can look into that , and if these provide a specfic advantage, we can shift to those.
@pranavtharoor commented on GitHub (Dec 13, 2017):
Are we also saving domain names? Currently it supports domains. If we change to non-string, then it won't support domains.
@nishchayp commented on GitHub (Dec 15, 2017):
Storing as string with front-end form validation seems fine.