[PR #168] [MERGED] Fix incorrect addition of empty name in MockDomainList if the config string contains AlternativeNames=; #283

New issue

Closed

opened 2026-02-26 12:34:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:34:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cbeuw/Cloak/pull/168
Author: @notsure2
Created: 7/22/2021
Status: ✅ Merged
Merged: 7/24/2021
Merged by: @cbeuw

Base: master ← Head: fix-empty-alternative-names

📝 Commits (1)

9d5c663 Fix incorrect addition of empty name in MockDomainList if the config string contains AlternativeNames=;

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 internal/client/state.go (+9 -0)

📄 Description

This bug is very visible and annoying on Android and makes Cloak unreliable (since it picks randomly between the empty name and the real ServerName).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cbeuw/Cloak/pull/168 **Author:** [@notsure2](https://github.com/notsure2) **Created:** 7/22/2021 **Status:** ✅ Merged **Merged:** 7/24/2021 **Merged by:** [@cbeuw](https://github.com/cbeuw) **Base:** `master` ← **Head:** `fix-empty-alternative-names` --- ### 📝 Commits (1) - [`9d5c663`](https://github.com/cbeuw/Cloak/commit/9d5c663618a9320901efda04097f3efa7f23f4bb) Fix incorrect addition of empty name in MockDomainList if the config string contains AlternativeNames=; ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/client/state.go` (+9 -0) </details> ### 📄 Description This bug is very visible and annoying on Android and makes Cloak unreliable (since it picks randomly between the empty name and the real ServerName). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>