[PR #141] [MERGED] Fix regression: termination of long downloads after StreamTimeout seconds #277

New issue

Closed

opened 2026-02-26 12:34:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:34:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cbeuw/Cloak/pull/141
Author: @notsure2
Created: 12/6/2020
Status: ✅ Merged
Merged: 12/12/2020
Merged by: @cbeuw

Base: master ← Head: fix-termination-of-long-downloads

📝 Commits (5)

ee5968a Fix termination of long downloads after StreamTimeout seconds.
3d103e7 When timeout no longer needs to be enforced, no need to schedule a broadcast.
2a18da0 Fix Cloak client. Don't enforce read deadline after first read.
35e1129 Enforce StreamTimeout on the initial bytes sent by localConn only.
9d6ab39 Revert changes to multiplex module. Remove timeout from caller.

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 internal/client/piper.go (+5 -3)
📝 internal/server/dispatcher.go (+0 -2)

📄 Description

Even if not broadcasting in a loop, we still need to update the read deadline.
Don't enforce the timeout after the first data is written.

Fixes #140

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cbeuw/Cloak/pull/141 **Author:** [@notsure2](https://github.com/notsure2) **Created:** 12/6/2020 **Status:** ✅ Merged **Merged:** 12/12/2020 **Merged by:** [@cbeuw](https://github.com/cbeuw) **Base:** `master` ← **Head:** `fix-termination-of-long-downloads` --- ### 📝 Commits (5) - [`ee5968a`](https://github.com/cbeuw/Cloak/commit/ee5968afee087e81acc40b146436ad28814cf1e4) Fix termination of long downloads after StreamTimeout seconds. - [`3d103e7`](https://github.com/cbeuw/Cloak/commit/3d103e728ce8abf8fd4d0a17f725c1bcdd290803) When timeout no longer needs to be enforced, no need to schedule a broadcast. - [`2a18da0`](https://github.com/cbeuw/Cloak/commit/2a18da037fce699d4d5bcf315e8748391f32578d) Fix Cloak client. Don't enforce read deadline after first read. - [`35e1129`](https://github.com/cbeuw/Cloak/commit/35e1129e05633ed8a4c920db244a72a003da8ed0) Enforce StreamTimeout on the initial bytes sent by localConn only. - [`9d6ab39`](https://github.com/cbeuw/Cloak/commit/9d6ab39a7737a43fa1f681a3fa42a6d47f176575) Revert changes to multiplex module. Remove timeout from caller. ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/client/piper.go` (+5 -3) 📝 `internal/server/dispatcher.go` (+0 -2) </details> ### 📄 Description - Even if not broadcasting in a loop, we still need to update the read deadline. - Don't enforce the timeout after the first data is written. Fixes #140 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 12:34:28 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Cloak#277

No description provided.

Rows
Columns