mirror of
https://github.com/cbeuw/Cloak.git
synced 2026-04-26 21:15:55 +03:00
[PR #115] [MERGED] Accept and ignore 2 parameters passed by shadowsocks-android in shadowsocks plugin mode. #271
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Cloak#271
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cbeuw/Cloak/pull/115
Author: @notsure2
Created: 5/27/2020
Status: ✅ Merged
Merged: 5/27/2020
Merged by: @cbeuw
Base:
master← Head:ignore-extra-parameters-plugin-mode📝 Commits (1)
c7b811fAccept and ignore 2 parameters passed by shadowsocks-android in shadowsocks plugin mode.📊 Changes
1 file changed (+4 additions, -0 deletions)
View changed files
📝
cmd/ck-client/ck-client.go(+4 -0)📄 Description
Since my previous pull request that allowed parameter parsing in shadowsocks mode, compiling latest Cloak-Android gave a non-working binary when used with shadowsocks-android.
In case of VPN mode and fast-open, shadowsocks-android intentionally passes up to 2 extra parameters (-V and --fast-open) to the SIP003 plugin. Since golang flag does not ignore unknown flags, it causes the plugin to start and fail immediately.
This pull request lets cloak accept and ignore those 2 parameters safely in shadowsocks mode.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.