[PR #104] [MERGED] Fix: server was timing out response from the proxy instead of the request from the client. #266

Closed
opened 2026-02-26 12:34:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cbeuw/Cloak/pull/104
Author: @notsure2
Created: 4/4/2020
Status: Merged
Merged: 4/4/2020
Merged by: @cbeuw

Base: masterHead: premature-tcp-close


📝 Commits (1)

  • 08446d6 Fix: server was timing out response from the proxy instead of the request from the client.

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 cmd/ck-server/ck-server.go (+2 -2)

📄 Description

This fixes a very annoying subtle bug, where the timeout was flipped on the client side in case of TCP only. So in case of a server resource that replies with empty TCP ACKs when receiving input (eg: idle SSH session sending SSH null packets to keep the connection alive), cloak was timing out the connection and killing it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cbeuw/Cloak/pull/104 **Author:** [@notsure2](https://github.com/notsure2) **Created:** 4/4/2020 **Status:** ✅ Merged **Merged:** 4/4/2020 **Merged by:** [@cbeuw](https://github.com/cbeuw) **Base:** `master` ← **Head:** `premature-tcp-close` --- ### 📝 Commits (1) - [`08446d6`](https://github.com/cbeuw/Cloak/commit/08446d6a14a508b6f412780af40e49fa5a8520eb) Fix: server was timing out response from the proxy instead of the request from the client. ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/ck-server/ck-server.go` (+2 -2) </details> ### 📄 Description This fixes a very annoying subtle bug, where the timeout was flipped on the client side in case of TCP only. So in case of a server resource that replies with empty TCP ACKs when receiving input (eg: idle SSH session sending SSH null packets to keep the connection alive), cloak was timing out the connection and killing it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 12:34:26 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Cloak#266
No description provided.