mirror of
https://github.com/cbeuw/Cloak.git
synced 2026-04-25 12:35:59 +03:00
[GH-ISSUE #121] Failed to decrypt a frame for session #101
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Cloak#101
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itman-co on GitHub (Jun 29, 2020).
Original GitHub issue: https://github.com/cbeuw/Cloak/issues/121
I have the following error on the server:
Jun 29 13:26:09 guest ck-server[2522]: time="2020-06-29T13:26:09Z" level=error msg="Failed to decrypt a frame for session 111641476: extra length is negative or extra length is greater than total pldWithOverHead length"
Environment:
Server: Debian 10
CK-Server 2.2.1
Shadowsocks-libev
Client: iPhone
App: Shadowrocket
Plugin: Cloak
@beanslel commented on GitHub (Jun 30, 2020):
This is a problem with Shadowrocket using an older version of the Cloak client, not a problem with Cloak itself. Several versions ago, TLS header length was changed and it's not backwards compatible with older versions. I ran into this problem myself recently and I already contacted the Shadowrocket developer. They said they would update the Cloak version, but this was several weeks ago and still waiting.
As a temporary workaround you can downgrade your Cloak server several versions and it should work again. I did a quick check and found This commit that changes the HEADER_LEN value, which is used to define pldWithOverHead length that's throwing the error. Version 2.0.2 is from before this commit, so you can try to downgrade the server to this version.
@cbeuw commented on GitHub (Jun 30, 2020):
@beanslel
If Shadowrocket uses a pre-2.1.0 client, then indeed it would be incompatible with 2.1.0+ servers.
@cbeuw commented on GitHub (Jun 30, 2020):
On another note, this is the first time I've heard of Shadowrocket. If they implement the Cloak protocol from scratch there wouldn't have been any licencing issues, but it appears that they bundle Cloak client binaries with their app. Cloak is licenced under GPLv3, what they are doing would have been fine if they include the licence and a link to Cloak's source code in their app. I don't have access to the app so I don't know if they've done that. Additionally if they've modified Cloak's source code, they need to release that under GPLv3 as well. I'm fairly certain they have modified the code, to 1. make Cloak work on iOS and 2. fix bugs, as indicated from their changelog.
It looks as though Shadowrocket is entirely proprietary, and from this repo's GitHub insight, the fixes mentioned in Shadowrocket's changelogs do not appear in any of the forked repos (the code could have been hosted elsewhere of course, but I didn't find any).
@beanslel commented on GitHub (Jun 30, 2020):
Hah, I didn't notice it but funnily enough Shadowrocket was updated 10h after this issue was raised and now it works again with the latest Cloak version.
Shadowrocket has been around for a while, it bundles ss/v2ray/cloak into a single app so it's convenient. I had a quick look and there is a link to this github in the app, but it does not appear to include the license.
Maybe you can email the dev about it, the email is buginapp at gmail dot com
@cbeuw commented on GitHub (Jun 30, 2020):
@beanslel Thanks for the info. I'm fine with them just leaving a link, but the main GPL issue is the modified source code. I couldn't test Cloak on iOS because I don't have a mac (thanks apple), but if someone else managed to do it that involves modification of Cloak, it'd be great (and indeed required by the licence) that they release it under a GPLv3 compatible licence so others can use it too.
I'll contact the devs regarding this. Thanks!
@itman-co commented on GitHub (Jul 1, 2020):
I have updated Shadowrocket to the latest version and it worked!
Thank you all.