mirror of
https://github.com/cbeuw/Cloak-android.git
synced 2026-04-25 19:45:50 +03:00
[GH-ISSUE #28] [enhancement]add 64bit version #22
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Cloak-android#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chenshaoju on GitHub (Oct 17, 2022).
Original GitHub issue: https://github.com/cbeuw/Cloak-android/issues/28
Current cloak-android only has a 32-bit version, in some cases, the newest phone maybe not support it. [The Pixel 7 series might be the first 64-bit-only Android phones]
and some phones may show a warning message:
Thanks for your hard work.
@fyrych commented on GitHub (Dec 2, 2022):
Hi. Downloaded today, and cannot install this app. Is it possible to create a 64 bit version?
Pixel 7 Pro.
@bingzhangdai commented on GitHub (Mar 21, 2023):
Same here. I am wondering about the effort of migrating to 64 bit. Will build with 64 bit sdk but no code change work?
@fyrych commented on GitHub (Mar 21, 2023):
I am changed ROM, installed custom rom for my phone. Problem with 32bit solved.
@bingzhangdai commented on GitHub (Mar 22, 2023):
Yes, I can install the x86 version, but there are some problems when launching the shadowsocks client with cloak plugin. Every time I have to manually open the cloak plugin then return to shadowsocks client (this leaves the cloak plugin running in the background), otherwise, the shadowsocks client won't start. It will complain "unknown plugin cloak". I suspect it is due to the compatibility problems of x86 version app.
@bingzhangdai commented on GitHub (Mar 22, 2023):
I can see that the build script already compiles the arm64 version apk:
github.com/cbeuw/Cloak-android@08ad33d70c/app/src/make.sh (L122). I think the owner can directly put the artifact to release page?@bingzhangdai commented on GitHub (Mar 22, 2023):
These android-strip tools are removed from NDK so that the cross platform compile fails.
github.com/cbeuw/Cloak-android@08ad33d70c/app/src/make.sh (L96)I commented these strip steps and manually built the apk. I can get the x64 version.However, "unknown plugin ck-client" is still there.
@cbeuw commented on GitHub (Mar 22, 2023):
x86_64, arm, and arm64 versions of the native Go lib are included in every APK, so this shouldn't have been the issue.
I was not aware of APKs being architecture specific, I'll look into this.
@bingzhangdai commented on GitHub (Mar 22, 2023):
@cbeuw This line failed
github.com/cbeuw/Cloak-android@08ad33d70c/app/src/make.sh (L124)Commented these strip steps will work.I suggest adding
set -ein the beginning of the script to force this build step to fail in Azure DevOps. Then you can notice the error.@cbeuw commented on GitHub (Mar 22, 2023):
This alone wouldn't fix the 32-bit APK issue, since existing releases were built successfully when NPK didn't remove
strip@bingzhangdai commented on GitHub (Mar 22, 2023):
Yes. I tried you project in Azure DevOps build. Actually your cross platform compile does fail.
You can add
set -ein the beginning or simply use&&between these commands@cbeuw commented on GitHub (Mar 22, 2023):
Ah yes you are right, it's been failing the whole time...
I'll fix the build script and make a new release
@bingzhangdai commented on GitHub (Mar 22, 2023):
btw, I found the solution to "unknown plugin": https://github.com/shadowsocks/shadowsocks-android/issues/1428. It is not related to the x64 bit version.
@bingzhangdai commented on GitHub (Mar 22, 2023):
@cbeuw Thank you. Another request, could you upload it to the play store? It will be more convenient, and the cellphone won't prompt the warning during installation.