[GH-ISSUE #116] MenuManager.swift line 314 #65

New issue

Closed

opened 2026-03-03 01:09:51 +03:00 by kerem · 2 comments

kerem commented

2026-03-03 01:09:51 +03:00

Owner

Originally created by @Econa77 on GitHub (Oct 29, 2016).
Original GitHub issue: https://github.com/Clipy/Clipy/issues/116

Originally assigned to: @Econa77 on GitHub.

in MenuManager.((makeClipMenuItem in _6E05F2567A8A9365E862DF96EA0D8059)(CPYClip, index : Int, listNumber : Int) -> NSMenuItem).(closure #1)

Number of crashes: 49
Impacted devices: 47

There's a lot more information about this crash on crashlytics.com:
https://fabric.io/econa77/mac/apps/com.clipy-app.clipy/issues/5795d053ffcdc04250663888

Originally created by @Econa77 on GitHub (Oct 29, 2016). Original GitHub issue: https://github.com/Clipy/Clipy/issues/116 Originally assigned to: @Econa77 on GitHub. #### in MenuManager.((makeClipMenuItem in _6E05F2567A8A9365E862DF96EA0D8059)(CPYClip, index : Int, listNumber : Int) -> NSMenuItem).(closure #1) - Number of crashes: 49 - Impacted devices: 47 There's a lot more information about this crash on crashlytics.com: [https://fabric.io/econa77/mac/apps/com.clipy-app.clipy/issues/5795d053ffcdc04250663888](https://fabric.io/econa77/mac/apps/com.clipy-app.clipy/issues/5795d053ffcdc04250663888)

kerem

2026-03-03 01:09:51 +03:00

closed this issue
added the
crash
label

kerem commented

2026-03-03 01:09:52 +03:00

Author

Owner

@algrid commented on GitHub (Nov 12, 2016):

Just as an hypothesis - in this piece of code:

PINCache.sharedCache().objectForKey(clip.thumbnailPath, block: { [weak menuItem] (cache, key, object) in
    if let image = object as? NSImage {
        menuItem?.image = image
    }
})

Is menuItem?.image = image executed on main thread? If no, it possibly can produce the crash.

@algrid commented on GitHub (Nov 12, 2016): Just as an hypothesis - in this piece of code: ``` PINCache.sharedCache().objectForKey(clip.thumbnailPath, block: { [weak menuItem] (cache, key, object) in if let image = object as? NSImage { menuItem?.image = image } }) ``` Is `menuItem?.image = image` executed on main thread? If no, it possibly can produce the crash.

kerem commented

2026-03-03 01:09:52 +03:00

Author

Owner

@Econa77 commented on GitHub (Nov 22, 2016):

@algrid Thanks for your advice. I fixed it 👍

@Econa77 commented on GitHub (Nov 22, 2016): @algrid Thanks for your advice. I fixed it 👍