[PR #447] [CLOSED] ［Fix］not correct index in submenu. #541

New issue

Closed

opened 2026-03-03 01:12:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:12:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Clipy/Clipy/pull/447
Author: @yebityon
Created: 1/21/2021
Status: ❌ Closed

Base: develop ← Head: issue_444

📝 Commits (5)

b4e9353 update MenuManager to fix issue #444
99b432b update MenuManager.swift
857b1d6 Merge branch 'develop' of https://github.com/Clipy/Clipy into issue_444
ebd7a1d fix inproper shortcut indexes
bbcc7ab update to remove warning

📊 Changes

1 file changed (+9 additions, -4 deletions)

View changed files

📝 Clipy/Sources/Managers/MenuManager.swift (+9 -4)

📄 Description

Problem

When turn on Menu items' title starts with 0 on preferences, the range of history & shortcut key are not correct.
Related #444

Diff

・Introduce new variable inmakeSubmenuItem & makeClipMenuItem to manage the index status.
・add some condition to fix indexes when isStartFromZero is true

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Clipy/Clipy/pull/447 **Author:** [@yebityon](https://github.com/yebityon) **Created:** 1/21/2021 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `issue_444` --- ### 📝 Commits (5) - [`b4e9353`](https://github.com/Clipy/Clipy/commit/b4e93535845374bb11ca79e96bb97c2bacec7a99) update MenuManager to fix issue #444 - [`99b432b`](https://github.com/Clipy/Clipy/commit/99b432be114bc407c2d962fd62b7cd8d1bbd2456) update MenuManager.swift - [`857b1d6`](https://github.com/Clipy/Clipy/commit/857b1d65db2c9f2a53c48c885c06f9dbd8a025ce) Merge branch 'develop' of https://github.com/Clipy/Clipy into issue_444 - [`ebd7a1d`](https://github.com/Clipy/Clipy/commit/ebd7a1dd78166cd740602adf72ef53f4ca0dfc28) fix inproper shortcut indexes - [`bbcc7ab`](https://github.com/Clipy/Clipy/commit/bbcc7abf3e305fe8d53896f6a75a237a0466f728) update to remove warning ### 📊 Changes **1 file changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Clipy/Sources/Managers/MenuManager.swift` (+9 -4) </details> ### 📄 Description ## Problem When turn on Menu items' title starts with 0 on preferences, the range of history & shortcut key are not correct. Related #444 ## Diff ・Introduce new variable in`makeSubmenuItem` & `makeClipMenuItem` to manage the index status. ・add some condition to fix indexes when `isStartFromZero` is `true` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>