[PR #123] [MERGED] Remove asset catalog images #442

New issue

Closed

opened 2026-03-03 01:12:25 +03:00 by kerem · 0 comments

kerem commented 2026-03-03 01:12:25 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/Clipy/Clipy/pull/123
Author: @Econa77
Created: 11/13/2016
Status: ✅ Merged
Merged: 11/13/2016
Merged by: @Econa77

Base: master ← Head: feature/image-assets

---

📝 Commits (1)

• 296d704 Remove asset catalog images

📊 Changes

92 files changed (+168 additions, -945 deletions)

View changed files

📝 Clipy.xcodeproj/project.pbxproj (+168 -0)
📝 Clipy/Extensions/NSImage+AssetCatalog.swift (+0 -6)
➖ Clipy/Images.xcassets/Commons/icon_application.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Commons/icon_application.imageset/icon_application@2x.png (+0 -0)
➖ Clipy/Images.xcassets/Commons/icon_folder.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Commons/icon_text.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/Contents.json (+0 -6)
➖ Clipy/Images.xcassets/Preferences/pref_beta.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_beta_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_excluded.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_excluded_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_general.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_general_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_menu.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_menu_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_shortcut.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_shortcut_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_type.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_type_on.imageset/Contents.json (+0 -21)
➖ Clipy/Images.xcassets/Preferences/pref_update.imageset/Contents.json (+0 -21)

...and 72 more files

📄 Description

Ccompiled with Sierra could not be started with Mavericks.
Ref: http://stackoverflow.com/questions/39616332/tokencount-maxcountincludingzeroterminator-assertion-osx-10-9

Moved image management from AssetCatalog to folder management.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Clipy/Clipy/pull/123 **Author:** [@Econa77](https://github.com/Econa77) **Created:** 11/13/2016 **Status:** ✅ Merged **Merged:** 11/13/2016 **Merged by:** [@Econa77](https://github.com/Econa77) **Base:** `master` ← **Head:** `feature/image-assets` --- ### 📝 Commits (1) - [`296d704`](https://github.com/Clipy/Clipy/commit/296d7041d0e0bb2b727f9b50b2ed9671ba360614) Remove asset catalog images ### 📊 Changes **92 files changed** (+168 additions, -945 deletions) <details> <summary>View changed files</summary> 📝 `Clipy.xcodeproj/project.pbxproj` (+168 -0) 📝 `Clipy/Extensions/NSImage+AssetCatalog.swift` (+0 -6) ➖ `Clipy/Images.xcassets/Commons/icon_application.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Commons/icon_application.imageset/icon_application@2x.png` (+0 -0) ➖ `Clipy/Images.xcassets/Commons/icon_folder.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Commons/icon_text.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/Contents.json` (+0 -6) ➖ `Clipy/Images.xcassets/Preferences/pref_beta.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_beta_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_excluded.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_excluded_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_general.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_general_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_menu.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_menu_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_shortcut.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_shortcut_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_type.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_type_on.imageset/Contents.json` (+0 -21) ➖ `Clipy/Images.xcassets/Preferences/pref_update.imageset/Contents.json` (+0 -21) _...and 72 more files_ </details> ### 📄 Description Ccompiled with Sierra could not be started with Mavericks. Ref: http://stackoverflow.com/questions/39616332/tokencount-maxcountincludingzeroterminator-assertion-osx-10-9 Moved image management from AssetCatalog to folder management. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-03-03 01:12:25 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

develop

feature/minimum-support-10.14-mojave

feature/fix-exclude-1password-browser-extensions

feature/new-pasteboard-type

master

feature/automatically-release

feature/import-export-history

refactor/menu-manager

1.2.1

1.2.0

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.10

1.0.9

1.0.8

1.0.7

1.0.6

1.0.5

1.0.4

1.0.3

1.0.2

1.0.1

1.0.1a

1.0.0

Labels

Clear labels   

bug

  

crash

  

crash

  

discussion

  

enhancement

  

enhancement

  

feature

  

invalid

  

pull-request

Mirrored from GitHub Pull Request

  

question

No labels

bug

crash

crash

discussion

enhancement

enhancement

feature

invalid

pull-request

question

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Clipy#442

No description provided.