starred/CIPP

Fork 0

mirror of https://github.com/KelvinTegelaar/CIPP.git synced 2026-04-25 08:16:01 +03:00

[GH-ISSUE #1833] RFFSelectSearch fields do not show validation errors visually #965

New issue

Closed

opened 2026-03-02 13:40:26 +03:00 by kerem · 3 comments

kerem commented

2026-03-02 13:40:26 +03:00

Owner

Originally created by @sk1tt1sh on GitHub (Oct 26, 2023).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1833

Description

Go to Add User in Identity
Fill out all fields except the usage location
Hit submit
The Usage Location field does not pass validation and the page shows all fields with green checks, except Usage Location which remains unchanged.

I tested locally and updated src/components/forms/RFFComponents.js RFFSelectSearch from:
<div><CFormLabel/>...<RFFCFormFeedback meta={meta} /></div>
to:
<div><CFormLabel/>...{meta.error && meta.touched && <span className="text-danger">{meta.error}</span>}</div>

Tried again and red "Required" showed underneath the field.

Not working:

With my change:

Environment data

Non-sponsored instance Front end version number: 4.4.0
Back end version number: 4.4.5
Tried Tenant Cache Clear: true
Tried Token Cache Clear: true

Originally created by @sk1tt1sh on GitHub (Oct 26, 2023). Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1833 ### Description 1. Go to Add User in Identity 2. Fill out all fields except the usage location 3. Hit submit 4. The Usage Location field does not pass validation and the page shows all fields with green checks, except Usage Location which remains unchanged. I tested locally and updated src/components/forms/RFFComponents.js RFFSelectSearch from: `<div><CFormLabel/>...<RFFCFormFeedback meta={meta} /></div>` to: `<div><CFormLabel/>...{meta.error && meta.touched && <span className="text-danger">{meta.error}</span>}</div>` Tried again and red "Required" showed underneath the field. Not working: ![image](https://github.com/KelvinTegelaar/CIPP/assets/2659377/2601b443-f73f-467d-98d7-74685f6bea68) With my change: ![image](https://github.com/KelvinTegelaar/CIPP/assets/2659377/fe0cd084-1de4-4efd-b3d4-7fe9602b7efd) ### Environment data ```PowerShell Non-sponsored instance Front end version number: 4.4.0 Back end version number: 4.4.5 Tried Tenant Cache Clear: true Tried Token Cache Clear: true ```

kerem

2026-03-02 13:40:26 +03:00

closed this issue
added the
bug

unconfirmed-by-user
labels

kerem commented

2026-03-02 13:40:27 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Oct 26, 2023):

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@github-actions[bot] commented on GitHub (Oct 26, 2023): Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/ If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.". Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

kerem commented

2026-03-02 13:40:27 +03:00

Author

Owner

@sk1tt1sh commented on GitHub (Oct 27, 2023):

I have updated to 4.5.0 frontend and backend, since submitting this issue and the behavior continues.

@sk1tt1sh commented on GitHub (Oct 27, 2023): I have updated to 4.5.0 frontend and backend, since submitting this issue and the behavior continues.

kerem commented

2026-03-02 13:40:27 +03:00

Author

Owner

@sk1tt1sh commented on GitHub (Oct 27, 2023):

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

@sk1tt1sh commented on GitHub (Oct 27, 2023): I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/CIPP#965

No description provided.

Rows
Columns