mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #1424] Outlook Spoof Warning Not Working #789
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#789
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @CorneliousJD on GitHub (Mar 20, 2023).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1424
Description
I had been in discussion via Discord with MrGeek who I know was also in discussion with you as well at some point on this.
The issue is that the spoof warning set to be turned on only logs in the CIPP logs as "Spoofing warnings set to false" when it should be ENABLING it for all of them.
What's worse is after manually enabling it and then manually running a standard, it gets RESET to false again.
If I check later with Get-ExternalInOutlook it confirms that the Spoof warning is indeed set to false.
Here's a sample of that.
My Standards config is a single line in the standards table for AllTenants -- no other standards applied.
Note that I have also deleted/recreated this table, and tried to delete/recreate the standard on 3.1.0 and 3.2.0 but issues persist the same regardless.
My actual standard config is here, with e-mails redacted.
{ "Tenant": "AllTenants", "AddedBy": "me@domain.net", "AppliedAt": "2023-03-17T20:35:42", "Standards": { "SendFromAlias": true, "DisableSelfServiceLicenses": true, "AutoExpandArchive": true, "AnonReportDisable": true, "PWdisplayAppInformationRequiredState": true, "DelegateSentItems": true, "AuditLog": true, "DisableViva": true, "DisableUserSiteCreate": true, "NudgeMFA": true, "PasswordExpireDisabled": true, "TAP": { "Enabled": true, "config": "true" }, "DeletedUserRentention": true, "ModernAuth": true, "MailContacts": { "MarketingContact": { "Enabled": true, "Mail": "365marketing@domain.net" }, "GeneralContact": { "Enabled": true, "Mail": "365general@domain.net" }, "SecurityContact": { "Enabled": true, "Mail": "365security@domain.net" }, "TechContact": { "Enabled": true, "Mail": "365technical@domain.net" } }, "SecurityDefaults": true, "SpoofWarn": { "enable": true } }}If I manually PowerShell into a tenant it does indeed let me enable it...
What's worse is after manually enabling it and then manually running a standard, it gets RESET to false again.
Environment data
@github-actions[bot] commented on GitHub (Mar 20, 2023):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://kelvintegelaar.github.io/CIPP
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@CorneliousJD commented on GitHub (Mar 20, 2023):
I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.
@CorneliousJD commented on GitHub (Mar 20, 2023):
Worked with Kelvin via Discord chat.
Tested by created a new individual standard for one tenant that included ONLY enable spoof warn, which worked.
{ "Tenant": "tenant.com", "AddedBy": "me@domain.net", "AppliedAt": "2023-03-20T17:46:25", "Standards": { "SpoofWarn": { "enable": true } }}Then I removed their individual standard and let them be part of the "AllTenants" standard again which flipped them back to having it disabled again. Confirmed this via Get-ExternalInOutlook cmdlet.
Once this is fixed under alltenants I can test and confirm that it is working correctly across various tenants.
@KelvinTegelaar commented on GitHub (Mar 21, 2023):
Fixed in dev. @BNWEIN See latest commit for the changed you needed to make.