mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #1340] SPF Details Falsely Reporting Failure on Domain #738
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#738
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ErlachSupport on GitHub (Jan 26, 2023).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1340
Description
One of my tenants is showing an error when doing an SPF check on their domain. When I looked into the SPF details, it showed it was expecting the default O365 SPF needed to be included at the beginning of the record despite existing near the end of the current record. I've moved the order and placed the O365 include statement near the front of the record. This resolved the SPF check error.
I am not sure if the SPF logic is meant to only check a certain number of statements before assuming the spf.protection.outlook.com record is missing. Scanners such as the MX Toolbox SPF checker do not show an error with the include placed at the end of the record. Attached a copy of the SPF details to show what is happening. Is this expected behavior?
Environment data
@github-actions[bot] commented on GitHub (Jan 26, 2023):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://kelvintegelaar.github.io/CIPP
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@JohnDuprey commented on GitHub (Jan 26, 2023):
That certainly sounds like a bug. If you're on Discord, send me a PM with some details so I can look into it.
@JohnDuprey commented on GitHub (Jan 26, 2023):
Disregard, it's one of your Barracuda MX lookups. One or both of them do not resolve anything and are causing an exception that breaks the SPF check. I've added some additional warnings for that.
@JohnDuprey commented on GitHub (Jan 26, 2023):
@ErlachSupport try to test the SPF record against The Kitterman SPF tool, it should report SPF ambiguous if my hunch is correct. https://www.kitterman.com/spf/validate.html
Example:
The explanation returned was, SPF Ambiguity Warning: No MX records found for mx mechanism@ErlachSupport commented on GitHub (Jan 26, 2023):
John, thank you for taking a look so quickly! I tested the record against the tool but it looks like it is coming back clean:
evaluating...
SPF record passed validation test with pySPF (Python SPF library)!
@ErlachSupport commented on GitHub (Jan 26, 2023):
I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.
@JohnDuprey commented on GitHub (Jan 26, 2023):
I still think it's a bug with the MX parsing - I'd like to see the record for that domain to confirm that it's fixed though. Happy to chat on Discord so you aren't publicly posting it.
@ErlachSupport commented on GitHub (Jan 26, 2023):
@johnduprey I've send a message via Discord. Thank you for digging into this!
@github-actions[bot] commented on GitHub (Feb 5, 2023):
This issue is stale because it has been open 10 days with no activity. We will close this issue soon. If you want this feature implemented you can contribute it. See: https://cipp.app/GettingStarted/Contributions/ . Please notify the team if you are working on this yourself.