starred/CIPP

Fork 0

mirror of https://github.com/KelvinTegelaar/CIPP.git synced 2026-04-25 16:26:09 +03:00

[GH-ISSUE #1279] BUG: Deploy Security Group Issues #712

New issue

Closed

opened 2026-03-02 12:44:34 +03:00 by kerem · 2 comments

kerem commented

2026-03-02 12:44:34 +03:00

Owner

Originally created by @mbohdeTA on GitHub (Dec 21, 2022).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1279

I've seen multiple issues pop up working with groups.

Groups > Add Groups
I haven't been able to recreate this a second time, but the first time I attempted to use this to deploy a Security Group, the Type selector kept switching back to Mail Enabled Security Group upon the first click after setting it back to Security Group. Apart from that first time, I can successfully deploy an individual group, even though it still requires an email address when it shouldn't need one for this type.

Deploy Group Templates > Select Tenant > Select Template (security group in this instance)
Where it shows Confirm and Apply, the first two show up correctly, but the third (type) has an X. Couple things here.

Not sure what it is, but there appears to be a rogue type box. The location depends on the size of the window, but full screen on 2560 x 1440, it's to the left of the Submit button.
There appears to be an issue with the Group Username field here. First, it shouldn't be a required field for Security Groups, as it isn't tied to an email account like the other types are (I think). When you enter the first part of the username, expecting it to take the default @domain, it fails asking for the full address, showing the group name with an @ at the end.

If you then go back and try adding the full address, it fails again, this time showing the full address with an @ at the end. It appears to be appending this @ regardless what you put in, so it will always fail.

I would expect working would be the Group Username being removed when Security Group is selected. I'm not quite sure how this is supposed to work with bulk deployments, but at least with individual deployments through template, you could also add the domain selector like the single group add page has to prevent any confusion there.

Originally created by @mbohdeTA on GitHub (Dec 21, 2022). Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1279 I've seen multiple issues pop up working with groups. Groups > Add Groups I haven't been able to recreate this a second time, but the first time I attempted to use this to deploy a Security Group, the Type selector kept switching back to Mail Enabled Security Group upon the first click after setting it back to Security Group. Apart from that first time, I can successfully deploy an individual group, even though it still requires an email address when it shouldn't need one for this type. ![image](https://user-images.githubusercontent.com/118937593/209017357-a58467ed-687b-4efe-bd3a-a2c8661735db.png) Deploy Group Templates > Select Tenant > Select Template (security group in this instance) Where it shows Confirm and Apply, the first two show up correctly, but the third (type) has an X. Couple things here. 1) Not sure what it is, but there appears to be a rogue type box. The location depends on the size of the window, but full screen on 2560 x 1440, it's to the left of the Submit button. ![image](https://user-images.githubusercontent.com/118937593/209016168-3761814d-02a7-414f-8211-f0118efe5a65.png) 2) There appears to be an issue with the Group Username field here. First, it shouldn't be a required field for Security Groups, as it isn't tied to an email account like the other types are (I think). When you enter the first part of the username, expecting it to take the default @domain, it fails asking for the full address, showing the group name with an @ at the end. ![image](https://user-images.githubusercontent.com/118937593/209016719-ca606808-9313-40e4-8cee-5435c2c5a3e9.png) If you then go back and try adding the full address, it fails again, this time showing the full address with an @ at the end. It appears to be appending this @ regardless what you put in, so it will always fail. ![image](https://user-images.githubusercontent.com/118937593/209016917-8c418801-d879-4b73-ae82-2bda0d4c03c2.png) I would expect working would be the Group Username being removed when Security Group is selected. I'm not quite sure how this is supposed to work with bulk deployments, but at least with individual deployments through template, you could also add the domain selector like the single group add page has to prevent any confusion there.

kerem

2026-03-02 12:44:34 +03:00

closed this issue
added the
unconfirmed-by-user
label

kerem commented

2026-03-02 12:44:35 +03:00

Author

Owner

@KelvinTegelaar commented on GitHub (Dec 22, 2022):

1.) This is your browser interpreting this. Most likely you have an adblocker active that is blocking the "ad" div, causing rendering issues

2.) The group username is the part before the @. no domain added.

@KelvinTegelaar commented on GitHub (Dec 22, 2022): 1.) This is your browser interpreting this. Most likely you have an adblocker active that is blocking the "ad" div, causing rendering issues 2.) The group username is the part before the @. no domain added.

kerem commented

2026-03-02 12:44:35 +03:00

Author

Owner

@mbohdeTA commented on GitHub (Dec 22, 2022):

For 1, no worries. I do have an ad blocker, but first time I've seen it cause that. For 2, I tried it with and without the domain, and both failed. I included screenshots of both failures.

-Mike Bohde
Insight Analyst

From: KelvinTegelaar @.>
Sent: Wednesday, December 21, 2022 7:22:00 PM
To: KelvinTegelaar/CIPP @.>
Cc: Mike Bohde @.>; Author @.>
Subject: Re: [KelvinTegelaar/CIPP] BUG: Deploy Security Group Issues (Issue #1279)

1.) This is your browser interpreting this. Most likely you have an adblocker active that is blocking the "ad" div, causing rendering issues

2.) The group username is the part before the @. no domain added.

—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKelvinTegelaar%2FCIPP%2Fissues%2F1279%23issuecomment-1362246564&data=05%7C01%7C%7C10f03c3a638c40e68cc108dae3b28b79%7C9182e874ec354aa7826394561a9d1c8c%7C0%7C0%7C638072653234962019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Rg%2FG2QXUB3gKYio%2FaQUXGmH1PcyY0Zu5uzh%2BMbo%2F6OU%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4LNP6LV2VFQ54FYMY3JKMTWOONKRANCNFSM6AAAAAATGDLTYI&data=05%7C01%7C%7C10f03c3a638c40e68cc108dae3b28b79%7C9182e874ec354aa7826394561a9d1c8c%7C0%7C0%7C638072653234962019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w5eGtg8HBukoNY6oeasqSSMDaYlbjEqc0JTECHXRxbA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

@mbohdeTA commented on GitHub (Dec 22, 2022): For 1, no worries. I do have an ad blocker, but first time I've seen it cause that. For 2, I tried it with and without the domain, and both failed. I included screenshots of both failures. -Mike Bohde Insight Analyst ________________________________ From: KelvinTegelaar ***@***.***> Sent: Wednesday, December 21, 2022 7:22:00 PM To: KelvinTegelaar/CIPP ***@***.***> Cc: Mike Bohde ***@***.***>; Author ***@***.***> Subject: Re: [KelvinTegelaar/CIPP] BUG: Deploy Security Group Issues (Issue #1279) 1.) This is your browser interpreting this. Most likely you have an adblocker active that is blocking the "ad" div, causing rendering issues 2.) The group username is the part before the @. no domain added. — Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKelvinTegelaar%2FCIPP%2Fissues%2F1279%23issuecomment-1362246564&data=05%7C01%7C%7C10f03c3a638c40e68cc108dae3b28b79%7C9182e874ec354aa7826394561a9d1c8c%7C0%7C0%7C638072653234962019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Rg%2FG2QXUB3gKYio%2FaQUXGmH1PcyY0Zu5uzh%2BMbo%2F6OU%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4LNP6LV2VFQ54FYMY3JKMTWOONKRANCNFSM6AAAAAATGDLTYI&data=05%7C01%7C%7C10f03c3a638c40e68cc108dae3b28b79%7C9182e874ec354aa7826394561a9d1c8c%7C0%7C0%7C638072653234962019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w5eGtg8HBukoNY6oeasqSSMDaYlbjEqc0JTECHXRxbA%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.***>

kerem referenced this issue

2026-03-02 13:56:19 +03:00

[PR #712] [MERGED] Bugfix for TenantSelectorMultiple #2981

kerem referenced this issue

2026-03-02 13:56:21 +03:00

[PR #719] [MERGED] Minor update for 2.1.1 #2985

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/CIPP#712

No description provided.

Rows
Columns