mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #1223] Exclude tenant icon brings up generic Add Excluded Tenants dialog #682
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#682
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joncz on GitHub (Nov 18, 2022).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1223
Description
CIPP->Settings->Tenants
If I click the eyeball icon beside a tenant to exclude them, I expected to receive a dialog that was basically a confirmation popup:
Exclude
[Continue] [Cancel]
Instead, I got the same popup as if I'd clicked the Add Excluded Tenant button at the top right, giving me the full list.
If you need to use that same dialog, I'd expect to see the selected tenant preselected
Environment data
@github-actions[bot] commented on GitHub (Nov 18, 2022):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://kelvintegelaar.github.io/CIPP
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@KelvinTegelaar commented on GitHub (Nov 18, 2022):
Whoops, oversight. Should indeed be a "Are you sure you want to exclude this tenant?" Fixing.
@KelvinTegelaar commented on GitHub (Nov 23, 2022):
fixed in dev