starred/CIPP

Fork 0

mirror of https://github.com/KelvinTegelaar/CIPP.git synced 2026-04-25 08:16:01 +03:00

[GH-ISSUE #107] BUG: Basic Auth Report only works on premium license tenants #62

New issue

Closed

opened 2026-03-02 12:03:33 +03:00 by kerem · 3 comments

kerem commented

2026-03-02 12:03:33 +03:00

Owner

Originally created by @gavsto on GitHub (Oct 22, 2021).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/107

Describe the bug
Basic Auth Report only works on premium license tenants

To Reproduce
This report does not run on all tenants

Expected behavior
This report SHOULD run on all tenants

A discussion needs to be had about how we handle this in the app. I am not personally keen on keeping reports that require certain licenses to work. As this stands at the moment, for a tenant where an appropriate license is not applied this will error out silently and just return as if there is no data whereas in reality that tenant may well be using basic auth. CIPP then ends up having given the person using it false information. @KelvinTegelaar feel this needs your input.

Originally created by @gavsto on GitHub (Oct 22, 2021). Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/107 **Describe the bug** Basic Auth Report only works on premium license tenants **To Reproduce** This report does not run on all tenants **Expected behavior** This report SHOULD run on all tenants A discussion needs to be had about how we handle this in the app. I am not personally keen on keeping reports that require certain licenses to work. As this stands at the moment, for a tenant where an appropriate license is not applied this will error out silently and just return as if there is no data whereas in reality that tenant may well be using basic auth. CIPP then ends up having given the person using it false information. @KelvinTegelaar feel this needs your input.

kerem closed this issue

2026-03-02 12:03:33 +03:00

kerem commented

2026-03-02 12:03:34 +03:00

Author

Owner

@KelvinTegelaar commented on GitHub (Oct 23, 2021):

@redanthrax added some wonderful error handling which is able to display when an API error occurs. I suggest that we either handle that in code(see MFAReports) or have APIs with a license requirement do a throw, when the license is not available. This way we cover reports that rely on only that data too.

the error could also be shown directly to the user, we just have to make sure we use the inner-error and not just the returned error code.

@KelvinTegelaar commented on GitHub (Oct 23, 2021): @redanthrax added some wonderful error handling which is able to display when an API error occurs. I suggest that we either handle that in code(see MFAReports) or have APIs with a license requirement do a throw, when the license is not available. This way we cover reports that rely on only that data too. the error could also be shown directly to the user, we just have to make sure we use the inner-error and not just the returned error code.

kerem commented

2026-03-02 12:03:34 +03:00

Author

Owner

@KelvinTegelaar commented on GitHub (Oct 23, 2021):

Also see KelvinTegelaar/CIPP-API: github.com/KelvinTegelaar/CIPP-API@2bbf083dc8

@KelvinTegelaar commented on GitHub (Oct 23, 2021): Also see KelvinTegelaar/CIPP-API: https://github.com/KelvinTegelaar/CIPP-API/commit/2bbf083dc8ec870eff519ccb04efaa9c09a9d194

kerem commented

2026-03-02 12:03:34 +03:00

Author

Owner

@KelvinTegelaar commented on GitHub (Oct 25, 2021):

Resolved.

@KelvinTegelaar commented on GitHub (Oct 25, 2021): Resolved.

kerem referenced this issue

2026-03-02 13:58:05 +03:00

[PR #1728] [MERGED] Add stretched-link to collapses #3383

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/CIPP#62

No description provided.

Rows
Columns