mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #1119] Suspect '&' In Company Name reduces functionality. #600
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#600
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TechEnvyPtyLtd on GitHub (Sep 12, 2022).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1119
Description
Some CIPP buttons are not working and I suspect it's when the company has an ampersand in the name as I'm seeing that pattern only.
Issue One
Click on Tenant Administration -> Administration -> List Tenants
Click on the '...' for a Tenant that contains a & in the Name and the button does nothing (no menu popups up etc).
Issue Two
Click on Tenant Administration -> Administration -> Standards (BPA)
Clicking on unused licenses for a company that contains the & in the name doesn't do anything (like it's not hyperlinked).
Environment data
@github-actions[bot] commented on GitHub (Sep 12, 2022):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://kelvintegelaar.github.io/CIPP
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@TechEnvyPtyLtd commented on GitHub (Sep 12, 2022):
I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.
@adamburley commented on GitHub (Sep 12, 2022):
Attempted to replicate - Ellipsis menu in List Tenants responds as I'd expect. I have seen the error you're reporting - usually the ellipsis is unresponsive but a blinking cursor appears, as if the input is being rendered as a text field. I haven't been able to narrow down when it occurs.
I am able to replicate the error in Standards > Best Practices Analyzer. It occurs if the tenant Company Name value contains any symbol other than period (.). My sample pool shows failures like this on comma, ampersand, hyphen, and parentheses. It appears the Company Name value may not be urlencoded for that query.
@KelvinTegelaar commented on GitHub (Sep 16, 2022):
Can't replicate in neither dev nor prod. The issue @adamburley has is related to another issue that has been solved in dev.