mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #1013] BUG: Standards not changing #534
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#534
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xtechsnik on GitHub (Jul 7, 2022).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1013
Describe the bug
A clear and concise description of what the bug is.
After enabling Disable Basic Authentication in standards when I uncheck check box and click edit standard it says it is saved. When I go back into standards check box is still checked and turned on.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
When I turn toggle off it should stay off.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
@KelvinTegelaar commented on GitHub (Jul 7, 2022):
cannot replicate, are you running the latest version of the frontend and API?
@xtechsnik commented on GitHub (Jul 7, 2022):
Hi,
Yes. I am running latest build on both.
Nik Margulski
MCSE | MCITP-E | MCP
From: KelvinTegelaar @.>
Sent: Thursday, July 7, 2022 1:49 PM
To: KelvinTegelaar/CIPP @.>
Cc: Nik Margulski @.>; Author @.>
Subject: Re: [KelvinTegelaar/CIPP] BUG: Standards not changing (Issue #1013)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
cannot replicate, are you running the latest version of the frontend and API?
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKelvinTegelaar%2FCIPP%2Fissues%2F1013%23issuecomment-1178210947&data=05%7C01%7Cnik%40xtechs.support%7Ce16909dd06b34329817c08da605a2f71%7C6a25496091d84bd99b6c75b94ce58383%7C0%7C0%7C637928237777410116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LboFkO4oQHDqzH%2B5pxgwB3JFs4Vd4MfyqsQSgnO65oQ%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZ5CSF5GGJE6RHH2PBQGVT3VS47FRANCNFSM526XMENA&data=05%7C01%7Cnik%40xtechs.support%7Ce16909dd06b34329817c08da605a2f71%7C6a25496091d84bd99b6c75b94ce58383%7C0%7C0%7C637928237777410116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2EbOLKrlyCgWu278jeOzu6wLOkpc%2BL69KEjjie0UK6Q%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>
@KelvinTegelaar commented on GitHub (Jul 7, 2022):
Just to check, you are unchecking the standard, scrolling down, and clicking "Edit Standard" right?
@xtechsnik commented on GitHub (Jul 7, 2022):
Hi. Yes. I unchecked the toggle then clicked Edit Standard at bottom.
When I check back a few minutes later that toggle is on.
@KelvinTegelaar commented on GitHub (Jul 7, 2022):
Have you tried refreshing the page? We tried across multiple instances and can't replicate. When saving the settings, navigating away or refrehsing the page you see the change directly reflected.
@xtechsnik commented on GitHub (Jul 7, 2022):
Hi. I have done that. I even signed out then back in.
@KelvinTegelaar commented on GitHub (Jul 7, 2022):
Wait, do you mean that it's still disabled inside of the tenant? That's expected behaviour and why we have the big banner pointing to the documentation at the Apply Standard screen.
@xtechsnik commented on GitHub (Jul 7, 2022):
Not inside the tenant. In the List and Edit Standards in CIPP.
@xtechsnik commented on GitHub (Jul 7, 2022):
Basically. I have went back into some of the tenants and re-enabled basic auth. I want to make sure the standards is not going to disable again.
@xtechsnik commented on GitHub (Jul 8, 2022):
Hi. So when I went to my home computer and made the change the change stuck. Looks good to go now. We can mark this one as closed. I do have another question. We are an MSP and have our tenants in our CIPP app. I have a co-managed client with internal IT. Can I deploy to their Azure and just use my fork from GIT or have them create a GIT account and fork from your repository? Thanks.
@KelvinTegelaar commented on GitHub (Jul 8, 2022):
You can reuse your fork for as many deployments as you want, up to 100. :)
@xtechsnik commented on GitHub (Jul 8, 2022):
Hi. I forgot to mention. When I checked from my home computer toggle was still on.
I turned off function app and waited 10 minutes then turned it back on.
After turning it back on when I toggled the basic auth it kept the settings.
Just an FYI in case it comes up anywhere else.
Also. A big thank you for creating such a great app.
@xtechsnik commented on GitHub (Oct 11, 2022):
I have turned off toggle and clicked Edit Standards and when go back it look like this.
[cid:f66d5667-ba0c-4b0a-8d94-85da9b7b5bba]
Nik Margulski
MCSE | MCITP-E | MCP
From: KelvinTegelaar @.>
Sent: Thursday, July 7, 2022 1:49 PM
To: KelvinTegelaar/CIPP @.>
Cc: Nik Margulski @.>; Author @.>
Subject: Re: [KelvinTegelaar/CIPP] BUG: Standards not changing (Issue #1013)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
cannot replicate, are you running the latest version of the frontend and API?
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKelvinTegelaar%2FCIPP%2Fissues%2F1013%23issuecomment-1178210947&data=05%7C01%7Cnik%40xtechs.support%7Ce16909dd06b34329817c08da605a2f71%7C6a25496091d84bd99b6c75b94ce58383%7C0%7C0%7C637928237777410116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LboFkO4oQHDqzH%2B5pxgwB3JFs4Vd4MfyqsQSgnO65oQ%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZ5CSF5GGJE6RHH2PBQGVT3VS47FRANCNFSM526XMENA&data=05%7C01%7Cnik%40xtechs.support%7Ce16909dd06b34329817c08da605a2f71%7C6a25496091d84bd99b6c75b94ce58383%7C0%7C0%7C637928237777410116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2EbOLKrlyCgWu278jeOzu6wLOkpc%2BL69KEjjie0UK6Q%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>