mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #993] FEATURE REQUEST: #522
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#522
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @servant42 on GitHub (Jun 25, 2022).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/993
Is your feature request related to a problem? Please describe.
When deploying CIPP for the first time, the time investment and complexity to create SAM tokens is high, but the code to do so programmatically exists in the SAM Wizard already.
Describe the solution you'd like
I suggest changing the installation flow to wait until after installation to ask for the SAM tokens, and walk the user through the SAM Wizard for the first time (if the tokens don't exist already, for example, which could also trigger if the user deletes the tokens as a way to prompt their regeneration, for admin users at least), with an alternate set of manual directions if it fails or needs troubleshooting, making the experience of first time and updated tokens similar and streamlining the installation.
Describe alternatives you've considered
Alternately, a checkbox to bypass the tokens and allow adding after install, if allowing them to be added up front is still desirable as an option. Or, add the wizard into the deployment process, but I suspect that dropping into the SAM wizard if the tokens don't exist on first login but after install is a simpler workflow.
Additional context
I admit it's been about a month or so since my last installation and it's possible I'm out of the loop and this is already addressed.
@KelvinTegelaar commented on GitHub (Jun 26, 2022):
already in dev.