mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #78] Feature request: Better logging #48
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#48
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @KelvinTegelaar on GitHub (Oct 19, 2021).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/78
Is your feature request related to a problem? Please describe.
The logging engine currently works by adding entries to a text file, using a mutex to prevent parallel write issues. This works OKish but could use some improvements.
I'd also like to have logs be in a better format. We currently use
I am proposing changing this to:
Each API should post to the log without exception. Severity levels should be:
By default, the log should only return the INFO/WARN/ERROR levels, and have a selection option for the full log.
@KelvinTegelaar commented on GitHub (Oct 19, 2021):
@KelvinTegelaar commented on GitHub (Oct 19, 2021):
@redanthrax added logging to the graph function, with a critical level for any actual call failure.
@KelvinTegelaar commented on GitHub (Oct 26, 2021):
And with the latest additions to the logging engine we can close this out. Logging interface can still use improvements, and that is planned in a new issue for 1.3