mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-26 00:36:27 +03:00
[GH-ISSUE #5457] [Bug]: GDAP Check still listing 12 GDAP groups #2631
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#2631
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joelmacklow on GitHub (Feb 24, 2026).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/5457
Originally assigned to: @Zacgoose on GitHub.
Required confirmations before submitting
Issue Description
In v10.1.1 the number of recommended GDAP role memberships seems to have increased from 12 to 15 as per https://docs.cipp.app/setup/installation/recommended-roles. The GDAP Check pane seems to imply that there are still only 12. Is it checking for 15 or still 12?
Steps
Environment Type
Non-sponsored user
Front End Version
v10.1.1
Back End Version
v10.1.1
Relevant Logs / Stack Trace
@github-actions[bot] commented on GitHub (Feb 24, 2026):
Thank you for reporting a potential bug. If you would like to work on this bug, please comment:
Thank you for helping us maintain the project!
@joelmacklow commented on GitHub (Feb 24, 2026):
Sidepoint: It is my understanding (I could be wrong here) that if the number of roles in a GDAP Role Template are changed then a new invitation for the tenant will need to be created and approved in all existing tenants that use that template and the previous existing GDAP relationship terminated.
Documentation suggestion: Perhaps the docs for https://docs.cipp.app/setup/installation/recommended-roles should clarify the above?
@CW-ZacR commented on GitHub (Feb 25, 2026):
I would like to work on this please!
@github-actions[bot] commented on GitHub (Feb 25, 2026):
Great! I assigned you (@CW-ZacR) to the issue. Have fun working on it!
@CW-ZacR commented on GitHub (Feb 25, 2026):
if the relationship contains the required roles (including new ones) then it'll be updated with your new GDAP permissions mapping. If the relationship does not contain the new roles you will need to do a new GDAP invite for those customers who have not got it. no easy way around it. Yes, it would also be best to remove the old ones as well once you have the new one established.
@Zacgoose commented on GitHub (Feb 25, 2026):
wrong account, should be this one haha
@Zacgoose commented on GitHub (Feb 25, 2026):
I would like to work on this please!
@github-actions[bot] commented on GitHub (Feb 25, 2026):
Sorry, can't help you here. This issue already has a volunteer.
@KelvinTegelaar commented on GitHub (Feb 25, 2026):
Fixed in dev