mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #3688] [Bug]: Password Pusher Integration - Generating incorrect links #1634
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#1634
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @365techCIPP on GitHub (Feb 24, 2025).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/3688
Required confirmations before submitting
Issue Description
Password Pusher integration is configured with our Pro Password Pusher account. PWPush URL: https://pwp.365tech.ca
Clicking on the Test but created a Password Push link but there is an extra /r at the end of the generated link. For example a link that is generated via the test button is:
https://pwp.365tech.ca/p/8h3cdst4ygib/r/r
The correct link should be the following instead:
https://pwp.365tech.ca/p/8h3cdst4ygib/r
We can confirm that the extra /r at the end of the link is also generated when a new user is created or when a user password is reset.
Environment Type
Sponsored (paying) user
Front End Version
v7.2.3
Back End Version
v7.2.3
Relevant Logs / Stack Trace
@github-actions[bot] commented on GitHub (Feb 24, 2025):
Thank you for reporting a potential bug. If you would like to work on this bug, please comment:
Thank you for helping us maintain the project!
@JohnDuprey commented on GitHub (Feb 24, 2025):
hey @365techCIPP if you've enforced the password retrieval in policy on PWP side, ensure that you do not also do so in CIPP for the time being
@365techCIPP commented on GitHub (Feb 24, 2025):
Thanks @JohnDuprey
We do enforce the Click to retrieve policy on the PWP side, but even after disabling the Click to retrieve password button on CIPP side it is still generating the extra /r on the end of the link.
We have disabled integration and reenabled it cleared browser cache, still the same.
Example:
https://pwp.365tech.ca/p/fe49cj_cellsyytji1e/r/r
@365techCIPP commented on GitHub (Feb 25, 2025):
For anyone else that faces the same issue the root cause of the issue is on the Password Pusher policy for Pushes.
1-Click Retrieval -> Default Value = true and set Force the default value to false
The Force the default value = true results in the double /r/r in the links generated in CIPP