starred/CIPP

Fork 0

mirror of https://github.com/KelvinTegelaar/CIPP.git synced 2026-04-25 16:26:09 +03:00

[GH-ISSUE #3621] [Bug]: Domains Analyser checkboxes #1608

New issue

Closed

opened 2026-03-02 13:45:35 +03:00 by kerem · 2 comments

kerem commented

2026-03-02 13:45:35 +03:00

Owner

Originally created by @bitjbullock on GitHub (Feb 12, 2025).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/3621

Required confirmations before submitting

I can reproduce this issue on the latest released versions of both CIPP and CIPP-API.
I have searched existing issues (both open and closed) to avoid duplicates.
I am not requesting general support; this is an actual bug report.

Issue Description

When trying to remove onmicrosoft.com domains from the Domain Analyser report list, we noticed that sometimes it would delete domains we had not selected. I was able to replicate this 3 separate times, and then of course realised I couldn't add the domain back in after my testing. oops.

Steps to reproduce:

Go to Domain Analyser under "All Tenants"
Using the check boxes select multiple domains (We used the onmicrosoft.com ones to clean up the list a bit)
Bulk Actions -> Delete from analyser
Once completed, select new domains
Bulk actions -> Delete from analyser
When this completes, the confirmation of completion will show domains that were not checked

I suspect that what's happening is the check box is associated with "Line X of chart" but then as you create filters, the line number changes that is associated with the domain the user is trying to select, so the back end ends up picking Line 4 as an example and line 4 is associated with contoso.com and the user sees line 4 associated with contoso.onmicrosoft.com and then inadvertently deletes a domain from the analyser that is needed.

I'll submit a secondary feature request but this brings up a good point, if you delete a domain from the domain analyser, there should be a way to add it back in.

Environment Type

Non-sponsored user

Front End Version

7.1.3

Back End Version

7.1.3

Relevant Logs / Stack Trace

Originally created by @bitjbullock on GitHub (Feb 12, 2025). Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/3621 ### Required confirmations before submitting - [x] **I can reproduce this issue on the latest released versions** of both CIPP and CIPP-API. - [x] **I have searched existing issues** (both open and closed) to avoid duplicates. - [x] I am **not** requesting general support; this is an actual bug report. ### Issue Description When trying to remove onmicrosoft.com domains from the Domain Analyser report list, we noticed that sometimes it would delete domains we had not selected. I was able to replicate this 3 separate times, and then of course realised I couldn't add the domain back in after my testing. oops. **Steps to reproduce:** 1. Go to Domain Analyser under "All Tenants" 2. Using the check boxes select multiple domains (We used the onmicrosoft.com ones to clean up the list a bit) 3. Bulk Actions -> Delete from analyser 4. Once completed, select new domains 5. Bulk actions -> Delete from analyser 6. When this completes, the confirmation of completion will show domains that were not checked I suspect that what's happening is the check box is associated with "Line X of chart" but then as you create filters, the line number changes that is associated with the domain the user is trying to select, so the back end ends up picking Line 4 as an example and line 4 is associated with contoso.com and the user sees line 4 associated with contoso.onmicrosoft.com and then inadvertently deletes a domain from the analyser that is needed. I'll submit a secondary feature request but this brings up a good point, if you delete a domain from the domain analyser, there should be a way to add it back in. ### Environment Type Non-sponsored user ### Front End Version 7.1.3 ### Back End Version 7.1.3 ### Relevant Logs / Stack Trace ```plaintext ```

kerem

2026-03-02 13:45:35 +03:00

closed this issue
added the
bug

unconfirmed-by-user
labels

kerem commented

2026-03-02 13:45:37 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Feb 12, 2025):

Thank you for reporting a potential bug. If you would like to work on this bug, please comment:

I would like to work on this please!

Thank you for helping us maintain the project!

@github-actions[bot] commented on GitHub (Feb 12, 2025): Thank you for reporting a potential bug. If you would like to work on this bug, please comment: > I would like to work on this please! Thank you for helping us maintain the project!

kerem commented

2026-03-02 13:45:37 +03:00

Author

Owner

@KelvinTegelaar commented on GitHub (Feb 13, 2025):

Fixed in dev

@KelvinTegelaar commented on GitHub (Feb 13, 2025): Fixed in dev

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/CIPP#1608

No description provided.

Rows
Columns