mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #3026] NinjaRMM Custom Field Device Link adding an extra "\device" to end of string causing broken link #1503
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#1503
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DavidHGAK on GitHub (Dec 28, 2024).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/3026
Description
We integrated NinjaRMM into CIPP for the convenient O365 tenant links we get in the custom fields tab. To view LAPS passwords we were hoping to click the Device Entra link but it generates a link like below with an extra "/deviceId" at the end:
https://entra.microsoft.com/tenant.com/#view/Microsoft_AAD_Devices/DeviceDetailsMenuBlade/~/Properties/deviceId/xxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxxxx/deviceId/
Notice at the end of the string is a 2nd "/deviceId" which seems to break the link. If I remove the 2nd "/deviceiD" manually from the end it points to the device's Entra page like we want!
It looks like it just needs to somehow generate these custom links without that ending.
Environment data
@github-actions[bot] commented on GitHub (Dec 28, 2024):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@MWG-Logan commented on GitHub (Dec 30, 2024):
Please note my changes have only been committed to the
interface-rewritebranch. If it gets merged, you'd probably need to wait until the rewrite goes prod.@KelvinTegelaar commented on GitHub (Jan 2, 2025):
Solved in beta! :)